Skip to content

Bumps max domains from 2 to 10 for approved API Apps #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jtreminio-dropbox merged 1 commit into from
Jun 24, 2025
Merged

Bumps max domains from 2 to 10 for approved API Apps #495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions openapi-raw.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7697,7 +7697,7 @@ components:
type: array
items:
type: string
maxItems: 2
maxItems: 10
minItems: 1
name:
description: '_t__ApiAppCreate::NAME'
Expand All @@ -7723,7 +7723,7 @@ components:
type: array
items:
type: string
maxItems: 2
maxItems: 10
name:
description: '_t__ApiAppUpdate::NAME'
type: string
Expand Down
4 changes: 2 additions & 2 deletions openapi-sdk.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7797,7 +7797,7 @@ components:
type: array
items:
type: string
maxItems: 2
maxItems: 10
minItems: 1
name:
description: 'The name you want to assign to the ApiApp.'
Expand All @@ -7823,7 +7823,7 @@ components:
type: array
items:
type: string
maxItems: 2
maxItems: 10
name:
description: 'The name you want to assign to the ApiApp.'
type: string
Expand Down
4 changes: 2 additions & 2 deletions openapi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7797,7 +7797,7 @@ components:
type: array
items:
type: string
maxItems: 2
maxItems: 10
minItems: 1
name:
description: 'The name you want to assign to the ApiApp.'
Expand All @@ -7823,7 +7823,7 @@ components:
type: array
items:
type: string
maxItems: 2
maxItems: 10
name:
description: 'The name you want to assign to the ApiApp.'
type: string
Expand Down
8 changes: 4 additions & 4 deletions sdks/php/src/Model/ApiAppCreateRequest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,8 +329,8 @@ public function listInvalidProperties()
if ($this->container['domains'] === null) {
$invalidProperties[] = "'domains' can't be null";
}
if (count($this->container['domains']) > 2) {
$invalidProperties[] = "invalid value for 'domains', number of items must be less than or equal to 2.";
if (count($this->container['domains']) > 10) {
$invalidProperties[] = "invalid value for 'domains', number of items must be less than or equal to 10.";
}

if (count($this->container['domains']) < 1) {
Expand Down Expand Up @@ -377,8 +377,8 @@ public function setDomains(array $domains)
throw new InvalidArgumentException('non-nullable domains cannot be null');
}

if (count($domains) > 2) {
throw new InvalidArgumentException('invalid value for $domains when calling ApiAppCreateRequest., number of items must be less than or equal to 2.');
if (count($domains) > 10) {
throw new InvalidArgumentException('invalid value for $domains when calling ApiAppCreateRequest., number of items must be less than or equal to 10.');
}
if (count($domains) < 1) {
throw new InvalidArgumentException('invalid length for $domains when calling ApiAppCreateRequest., number of items must be greater than or equal to 1.');
Expand Down
8 changes: 4 additions & 4 deletions sdks/php/src/Model/ApiAppUpdateRequest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,8 +326,8 @@ public function listInvalidProperties()
{
$invalidProperties = [];

if (!is_null($this->container['domains']) && (count($this->container['domains']) > 2)) {
$invalidProperties[] = "invalid value for 'domains', number of items must be less than or equal to 2.";
if (!is_null($this->container['domains']) && (count($this->container['domains']) > 10)) {
$invalidProperties[] = "invalid value for 'domains', number of items must be less than or equal to 10.";
}

return $invalidProperties;
Expand Down Expand Up @@ -421,8 +421,8 @@ public function setDomains(?array $domains)
throw new InvalidArgumentException('non-nullable domains cannot be null');
}

if (count($domains) > 2) {
throw new InvalidArgumentException('invalid value for $domains when calling ApiAppUpdateRequest., number of items must be less than or equal to 2.');
if (count($domains) > 10) {
throw new InvalidArgumentException('invalid value for $domains when calling ApiAppUpdateRequest., number of items must be less than or equal to 10.');
}
$this->container['domains'] = $domains;

Expand Down
2 changes: 1 addition & 1 deletion sdks/python/dropbox_sign/models/api_app_create_request.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ class ApiAppCreateRequest(BaseModel):
ApiAppCreateRequest
""" # noqa: E501

domains: Annotated[List[StrictStr], Field(min_length=1, max_length=2)] = Field(
domains: Annotated[List[StrictStr], Field(min_length=1, max_length=10)] = Field(
description="The domain names the ApiApp will be associated with."
)
name: StrictStr = Field(description="The name you want to assign to the ApiApp.")
Expand Down
2 changes: 1 addition & 1 deletion sdks/python/dropbox_sign/models/api_app_update_request.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ class ApiAppUpdateRequest(BaseModel):
default=None,
description="An image file to use as a custom logo in embedded contexts. (Only applies to some API plans)",
)
domains: Optional[Annotated[List[StrictStr], Field(max_length=2)]] = Field(
domains: Optional[Annotated[List[StrictStr], Field(max_length=10)]] = Field(
default=None, description="The domain names the ApiApp will be associated with."
)
name: Optional[StrictStr] = Field(
Expand Down
10 changes: 5 additions & 5 deletions sdks/ruby/lib/dropbox-sign/models/api_app_create_request.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,8 +165,8 @@ def list_invalid_properties
invalid_properties.push('invalid value for "domains", domains cannot be nil.')
end

if @domains.length > 2
invalid_properties.push('invalid value for "domains", number of items must be less than or equal to 2.')
if @domains.length > 10
invalid_properties.push('invalid value for "domains", number of items must be less than or equal to 10.')
end

if @domains.length < 1
Expand All @@ -184,7 +184,7 @@ def list_invalid_properties
# @return true if the model is valid
def valid?
return false if @domains.nil?
return false if @domains.length > 2
return false if @domains.length > 10
return false if @domains.length < 1
return false if @name.nil?
true
Expand All @@ -196,8 +196,8 @@ def domains=(domains)
if domains.nil?
fail ArgumentError, 'domains cannot be nil'
end
if domains.length > 2
fail ArgumentError, 'invalid value for "domains", number of items must be less than or equal to 2.'
if domains.length > 10
fail ArgumentError, 'invalid value for "domains", number of items must be less than or equal to 10.'
end

if domains.length < 1
Expand Down
10 changes: 5 additions & 5 deletions sdks/ruby/lib/dropbox-sign/models/api_app_update_request.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,8 +161,8 @@ def initialize(attributes = {})
# @return Array for valid properties with the reasons
def list_invalid_properties
invalid_properties = Array.new
if !@domains.nil? && @domains.length > 2
invalid_properties.push('invalid value for "domains", number of items must be less than or equal to 2.')
if !@domains.nil? && @domains.length > 10
invalid_properties.push('invalid value for "domains", number of items must be less than or equal to 10.')
end

invalid_properties
Expand All @@ -171,15 +171,15 @@ def list_invalid_properties
# Check to see if the all the properties in the model are valid
# @return true if the model is valid
def valid?
return false if !@domains.nil? && @domains.length > 2
return false if !@domains.nil? && @domains.length > 10
true
end

# Custom attribute writer method with validation
# @param [Object] domains Value to be assigned
def domains=(domains)
if domains.length > 2
fail ArgumentError, 'invalid value for "domains", number of items must be less than or equal to 2.'
if domains.length > 10
fail ArgumentError, 'invalid value for "domains", number of items must be less than or equal to 10.'
end

@domains = domains
Expand Down