Skip to content

Address security concerns from older version of remarkable #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Address security concerns from older version of remarkable #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
492e69c
Updates remarkable plugin
cmcculloh-kr Oct 30, 2023
db40603
Matches library's formatting preferences
cmcculloh-kr Nov 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@

var hljs = require('highlight.js');
var utils = require('handlebars-utils');
var Remarkable = require('remarkable');
const { Remarkable } = require('remarkable');
const { linkify } = require('remarkable/linkify');

var defaults = { html: true, breaks: true, highlight: highlight };

module.exports = function(config) {
Expand Down Expand Up @@ -30,7 +32,14 @@ module.exports = function(config) {
opts.langPrefix = opts.lang;
}

var md = new Remarkable(opts);
const useLinkify = opts.linkify;
delete opts.linkify;

let md = new Remarkable(opts);
if (useLinkify) {
md.use(linkify);
}

var val = utils.value(str, ctx, options);
return md.render(val);
}
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"dependencies": {
"handlebars-utils": "^1.0.2",
"highlight.js": "^9.12.0",
"remarkable": "^1.7.1"
"remarkable": "^2.0.1"
},
"devDependencies": {
"gulp-format-md": "^1.0.0",
Expand Down