Skip to content

[Snyk] Security upgrade urllib3 from 2.0.7 to 2.5.0 #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
henols wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Snyk] Security upgrade urllib3 from 2.0.7 to 2.5.0 #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,5 @@ pyserial
requests
tqdm
argcomplete
rich
rich
urllib3>=2.5.0 # not directly required, pinned by Snyk to avoid a vulnerability
Copy link

@gemini-code-assist gemini-code-assist bot Jul 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While this change is important for security, directly pinning a transitive dependency like urllib3 can create dependency conflicts.

The requests library, a direct dependency of your project, has specific version constraints for urllib3:

  • requests < 2.32.0 (e.g., 2.31.0) requires urllib3 < 2.1, making it incompatible with this change.
  • requests >= 2.32.0 is compatible with urllib3 >= 2.5.0.

This means that for this upgrade to work correctly, requests must also be at version 2.32.0 or newer. Without an explicit constraint on requests, pip might fail to resolve dependencies, especially in environments with an older requests version.

To make this requirement clear and prevent future build issues, I suggest adding a note to the comment.

On a related note, I see dependencies are managed in both requirements.txt and pyproject.toml. For better maintainability, consider consolidating them into pyproject.toml as the single source of truth.

urllib3>=2.5.0 # not directly required, pinned by Snyk to avoid a vulnerability; requires requests>=2.32.0