Conversation
Collaborator
|
I tested your changes and everything builds without issue but it does cause issues with the applet. The device never shows in the applet menu (the offline device placeholder feature is broken) and d-bus service no longer stops on log out. I am working on a new PR that implements the telephony feature and has some rework to fix the race condition (which you were correct about in the Issue #40.) I will update the dependencies and test it. |
Collaborator
|
@hepp3n When you say "We don't really need this" do you mean the service disconnect on logout? I think I would be fine with this either way but I thought we talked about this so time ago and agreed that it would be better to disconnect the service on logout |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just updated dependencies with latest libcosmic. Required some changes related to layout.
First look, seems OK. Please @M4L-C0ntent review and see if everything is on place :)