Escape special chars in topic and skip mono#45
Open
idbrii wants to merge 1 commit intoheraldofsolace:masterfrom
Open
Escape special chars in topic and skip mono#45idbrii wants to merge 1 commit intoheraldofsolace:masterfrom
idbrii wants to merge 1 commit intoheraldofsolace:masterfrom
Conversation
Owner
|
Looks good. Can you add some tests in |
Fix heraldofsolace#36. If the topic contains chars that make markdown formatting difficult, escape them and omit fixed width styling. Markdown parsers are often inconsistent, so hopefully simpler markdown is more likely to display properly for more users. Never deployed or run. (I'm not setup for either.)
Author
|
I added some tests. I don't have reddit's API auth or whatever else is necessary run it locally so I didn't try running the tests directly. They're a port of my above test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #36.
If the topic contains chars that make markdown formatting difficult (
[]`), escape them and omit fixed width styling.Markdown parsers are often inconsistent, so hopefully simpler markdown is more likely to display properly for more users.
Never deployed, but I've tested the code separately based on some examples from #36. I don't know what actual values pop out of the db for
topic-- I've guessed them based on vimhelpbot's responses.My test code:
Which produces results that look okay on old reddit and new reddit: