Delete unused code / minor refactor to reduce IDE warnings#1005
Delete unused code / minor refactor to reduce IDE warnings#1005hernanponcedeleon merged 2 commits intodevelopmentfrom
Conversation
Reformat code (reduce IDE warnings)
| import com.dat3m.dartagnan.program.event.arch.ptx.*; | ||
| import com.dat3m.dartagnan.program.event.arch.ptx.PTXAtomCAS; | ||
| import com.dat3m.dartagnan.program.event.arch.ptx.PTXAtomExch; | ||
| import com.dat3m.dartagnan.program.event.arch.ptx.PTXAtomOp; | ||
| import com.dat3m.dartagnan.program.event.arch.ptx.PTXRedOp; |
There was a problem hiding this comment.
Revert this (I do not even understand why your IDE goes from explicit to * in other parts and from * to explicit here).
There are other files where this gets expanded, revert those too
There was a problem hiding this comment.
Do we have a rule-of-thumb of when we want to use explicit imports? Would you already want to use .* for just two imports?
EDIT: It seems my IDE collapses import to .* when 5 classes get imported from the same package.
There was a problem hiding this comment.
If the whole package only contains two imports (my comment "There are other files ..." refers to svcomp package which only has two classes), then I would say yes.
As a rule-of-thumbs I would say: "do not import e.g., the whole java.utils unnecessarily, but if the package just contains a few classes (this would cover e.g., all our event and expressions packages) go for *"
| // GPUs | ||
| || def instanceof SameScope || def instanceof SyncWith | ||
| || def instanceof SyncFence || def instanceof SyncBar || def instanceof SameVirtualLocation | ||
| || def instanceof Free; |
There was a problem hiding this comment.
now it kind of looks like this is related to GPUs. I would move it together with AMOPairs and SameInstruction
2 participants
There are no functional changes in this PR.
EDIT: Okay, there is one bug fix that I accidentally committed as well. It's a single line of code added in cutting: