Skip to content
This repository was archived by the owner on Oct 16, 2024. It is now read-only.

Anchor tags #11

Open
shavit wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Anchor tags #11

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01b75a3
HTML links, instead JS on the anchor tags
Feb 18, 2013
7c34840
base tag
Feb 18, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions views/index.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<!DOCTYPE html>
<html xmlns:fb="http://ogp.me/ns/fb#" lang="en">
<html xmlns:fb="https://ogp.me/ns/fb#" lang="en">
<head>
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=2.0, user-scalable=yes" />
Expand All @@ -24,6 +24,8 @@
<meta property="og:site_name" content="<%= @app['name'] %>" />
<meta property="og:description" content="My First App" />
<meta property="fb:app_id" content="<%= @app['name'] %>" />

<base target="_blank" />

<script type="text/javascript" src="/javascripts/jquery-1.7.1.min.js"></script>

Expand Down Expand Up @@ -182,7 +184,7 @@
<ul class="friends">
<% @friends.each do |friend| %>
<li>
<a href="#" onclick="window.open('http://www.facebook.com/<%= friend['id']%>')">
<a href="https://www.facebook.com/<%= friend['id'] %>" target="_blank">
<img src="https://graph.facebook.com/<%= friend['id'] %>/picture?type=square" alt="<%= friend['name'] %>">
<%= friend['name'] %>
</a>
Expand All @@ -196,7 +198,7 @@
<ul class="photos">
<% @photos.each_with_index do |photo, index| %>
<li style="background-image: url(<%= photo['picture'] %>)" class='<%= 'first-column' if (index%4).zero? %>'>
<a href="#" onclick="window.open('http://www.facebook.com/<%= photo['id'] %>')">
<a href="https://www.facebook.com/<%= photo['id'] %>" target="_blank">
<%= photo['name'] %>
</a>
</li>
Expand All @@ -209,7 +211,7 @@
<ul class="things">
<% @likes.each do |like| %>
<li>
<a href="#" onclick="window.open('http://www.facebook.com/<%= like['id'] %>')">
<a href="https://www.facebook.com/<%= like['id'] %>" target="_blank">
<img src="https://graph.facebook.com/<%= like['id'] %>/picture?type=square" alt="<%= like['name'] %>">
<%= like['name'] %>
</a>
Expand All @@ -223,7 +225,7 @@
<ul class="friends">
<% @friends_using_app.each do |friend_result| %>
<li>
<a href="#" onclick="window.open('http://www.facebook.com/<%= friend_result['uid'] %>')">
<a href="https://www.facebook.com/<%= friend_result['uid'] %>" target="_blank">
<img src="<%= friend_result['pic_square'] %>" alt="<%= friend_result['name'] %>">
<%= friend_result['name'] %>
</a>
Expand Down