Remove hardcoded qt directory for mac build script#116
Open
SoCuul wants to merge 1 commit intohetelek:masterfrom
Open
Remove hardcoded qt directory for mac build script#116SoCuul wants to merge 1 commit intohetelek:masterfrom
SoCuul wants to merge 1 commit intohetelek:masterfrom
Conversation
hetelek
reviewed
Oct 21, 2025
| find ./Velocity/build | ||
|
|
||
| "$QT_BIN_PATH/macdeployqt6" ./Velocity/build/Velocity-OSX/release/Velocity.app | ||
| $QT_BIN_PATH/macdeployqt6 ./Velocity/build/Velocity-OSX/release/Velocity.app |
Owner
There was a problem hiding this comment.
We should either delete the $QT_BIN_PATH/ here or keep the QT_BIN_PATH=...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since most package managers (eg. homebrew) will put the qt binaries in the system path, there is no need to reference a specific directory for qt binaries. Additionally, you will not have to update the version in the path each time you update qt.