Conversation
Owner
|
@robotpistol I would defer to you on this PR. It seems reasonable to me, but not sure how I'd structure something like this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just the start. But this piece took me way longer than I'd like to admit. I did take the time to learn a bit more about elixir and how alex koin work though. Tests would be a whole other pain and I could prob use some pairing/help on that part.
Next... we'd need to agree upon a good interaction between slack and alex koin for this. I.e. how do people chose the image they want to use.
Another caveat here is that imgflip is likely not going to store these forever. So we either have to be happy with it being short lived or figure out our own way of hosting our own images. (Maybe higher koin price for that)
So this is like 10% of the problem, but its a start. This works functionally in alex-koin-elixir-console :D
https://imgflip.com/api