Skip to content

update validation error messages in schemas for improved clarity #2144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vtm9 merged 2 commits into from
Apr 18, 2025
Merged

update validation error messages in schemas for improved clarity #2144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e540f95
update validation error messages in schemas for improved clarity
driveGosling Apr 15, 2025
6719921
update validation error messages in schemas for improved clarity
driveGosling Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion services/app/apps/codebattle/assets/js/__tests__/UserSettings.test.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ describe('UserSettings test cases', () => {

expect(
await findByText(
/Should contain Latin letters, numbers and underscores. Only begin with latin letter/i,
/Must consist of Latin letters, numbers and underscores. Only begin with latin letter/i,
),
).toBeInTheDocument();
expect(submitButton).toBeDisabled();
Expand Down
4 changes: 2 additions & 2 deletions services/app/apps/codebattle/assets/js/widgets/formik/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ const schemas = {
)
.matches(
/^[a-zA-Z]+[a-zA-Z0-9_-\s{1}][a-zA-Z0-9_]+$/i,
'Should contain Latin letters, numbers and underscores. Only begin with latin letter',
'Must consist of Latin letters, numbers and underscores. Only begin with latin letter',
)
.trim(),
clan: Yup.string()
Expand Down Expand Up @@ -69,7 +69,7 @@ const schemas = {
.max(16, 'Should be from 3 to 16 characters')
.matches(
/^[a-zA-Z]+[a-zA-Z0-9_-\s{1}][a-zA-Z0-9_]+$/i,
'Should contain Latin letters, numbers and underscores. Only begin with latin letter',
'Must consist of Latin letters, numbers and underscores. Only begin with latin letter',
)
.required('Nickname required'),
email: emailSchema,
Expand Down
Loading