Drop duplicate P&L cards, rename section to Premium Economics#41
Merged
heyitsStylez merged 1 commit intomainfrom May 6, 2026
Merged
Drop duplicate P&L cards, rename section to Premium Economics#41heyitsStylez merged 1 commit intomainfrom
heyitsStylez merged 1 commit intomainfrom
Conversation
…40) Hero band is the canonical Realised/Unrealised/Total surface (per ADR 0004). Remove the duplicated cards from the Total tab and rename the section to reflect what it uniquely answers: premium economics. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #40.
Summary
pnl-tiles.test.js: dropped 6 obsolete card tests, added an absence test + a section-rename test. Hero coverage already lives inhero-total-tile.test.js.Tradeoff to flag
Removing the cards means asset-filtered Realised/Unrealised/Total numbers only appear above the fold. Judged worth it to eliminate duplication.
Section name picked: "Premium Economics" (issue allowed "Wheel Performance" as alternative — easy swap if preferred).
Test plan
python3 build.py --checkpassesnpm testpasses (58/58)hyperwheel.html— 4 cards, no Realised/Unrealised/Total🤖 Generated with Claude Code