Skip to content

HHH-14270 GroupedSchemaValidatorImpl / NameSpaceTablesInformation does not find different-case table information in case insensitive environment #10429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

HHH-14270 GroupedSchemaValidatorImpl / NameSpaceTablesInformation does not find different-case table information in case insensitive environment #10429

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion ...-core/src/main/java/org/hibernate/tool/schema/extract/spi/NameSpaceTablesInformation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,15 @@ public void addTableInformation(TableInformation tableInformation) {
}

public TableInformation getTableInformation(Table table) {
return tables.get( identifierHelper.toMetaDataObjectName( table.getQualifiedTableName().getTableName() ) );
String tableName = identifierHelper.toMetaDataObjectName( table.getQualifiedTableName().getTableName() );
if ( tables.containsKey( tableName.toLowerCase() )) {
return tables.get( tableName.toLowerCase() );
}
else if ( tables.containsKey( tableName.toUpperCase() ) ) {
return tables.get( tableName.toUpperCase() );
}

return null;
Comment on lines +29 to +37
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try using the same qualifier both when putting and getting informations from the tables map: you could try invoking identifierHelper.toMetaDataObjectName in the addTableInformation method or, inversely, using tableInformation.getName().getTableName().getText() here to use the same string.

}

public TableInformation getTableInformation(String tableName) {
Expand Down