display QR codes for device auth flows #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the call site in main() exits on error, so this seems unnecessary here
ccmtaylor
force-pushed
the
device-qrcode
branch
2 times, most recently
from
661e5c4 to
1726118
Compare
use package rsc.io/qr to generate QR codes and display them in the terminal using ANSI escape codes.
ccmtaylor
force-pushed
the
device-qrcode
branch
from
1726118 to
3975945
Compare
|
tested with |
|
Super cool! Works for me too. Before merging, I'll check the packaging implications for Debian and Fedora... |
|
Fedora has 0.2.0 https://packages.fedoraproject.org/pkgs/golang-rsc-qr/golang-rsc-qr-devel/ Debian has an older, untagged version |
|
Would you like me to make any changes to the PR? I’m on vacation this week and won’t be able to address this until Monday.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use package rsc.io/qr to generate QR codes and display them in the terminal using ANSI escape codes.
Screenshot:
inspired by #41, but doesn't require installing a separate cli tool