Feature: supports dynamic interface switching#143
Merged
hideakitai merged 10 commits intomainfrom Oct 16, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
Adds runtime-polymorphic interfaces (Sender/Receiver/Manager traits) to allow dynamic switching between network interfaces (WiFi/Ethernet) and simultaneous multi-interface usage. Updates examples, CI, version, and documentation accordingly.
- Introduces interface trait headers (SenderTraits, ReceiverTraits, ManagerTraits) and integrates them into Sender/Receiver/Manager classes.
- Adds new Multiple examples (switch_interface, send_receive) plus CI job to compile them.
- Bumps version to 0.9.0 and tightens ArxTypeTraits dependency; updates README with multi-interface guidance.
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| library.properties | Version bump and dependency minimum version added. |
| library.json | Mirrors version/dependency updates. |
| examples/Multiple/switch_interface/switch_interface.ino | New example demonstrating runtime interface switching. |
| examples/Multiple/send_receive/send_receive.ino | New example using WiFi and Ethernet concurrently. |
| README.md | Documents multi-interface support. |
| Artnet/SenderTraits.h | Adds sender interface trait (runtime polymorphism). |
| Artnet/Sender.h | Adapts Sender to new trait, adds optional port parameter. |
| Artnet/ReceiverTraits.h | Adds receiver interface trait. |
| Artnet/Receiver.h | Conforms to trait interface; replaces templated subscribe helpers with typed callbacks. |
| Artnet/ManagerTraits.h | Defines combined manager interface. |
| Artnet/Manager.h | Manager now implements new IManager interface; minor refactor. |
| .github/workflows/build.yml | Adds CI job to build new Multiple examples on several boards. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
8dd1ea8 to
eee3ce6
Compare
17a0449 to
970c03e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: