Skip to content

Fix: millis() overflow using PollingTimer#146

Merged
hideakitai merged 2 commits intomainfrom
fix/millis-overflow
Oct 17, 2025
Merged

Fix: millis() overflow using PollingTimer#146
hideakitai merged 2 commits intomainfrom
fix/millis-overflow

Conversation

@hideakitai
Copy link
Owner

Fix #127

@hideakitai hideakitai requested a review from Copilot October 17, 2025 13:45
@hideakitai hideakitai self-assigned this Oct 17, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a millis() overflow issue by replacing Arduino's millis() function with the PollingTimer library for more robust time tracking in Art-Net streaming operations.

  • Adds PollingTimer as a dependency to handle timing without overflow issues
  • Replaces uint32_t time tracking with double precision timing from PollingTimer
  • Updates time interval calculations to use floating-point arithmetic

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
library.properties Adds PollingTimer as a required dependency
library.json Adds PollingTimer dependency with version wildcard
Artnet/Sender.h Integrates PollingTimer for time tracking in streaming methods
Artnet/Common.h Updates interval constant and time map to use double precision

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@hideakitai hideakitai merged commit 50ac38c into main Oct 17, 2025
29 checks passed
@hideakitai hideakitai deleted the fix/millis-overflow branch October 17, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue with millis() overflowing

2 participants