Fix: type confliction if using WiFi and ETH#147
Merged
hideakitai merged 3 commits intomainfrom Oct 17, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
Introduces a wrapper UDP type (ETHUdp) to eliminate template/type conflicts when using both WiFi and Ethernet ArtNet managers concurrently, and adds a combined send/receive example for WiFi + Ethernet.
- Defines ETHUdp (deriving from WiFiUDP) and updates template specializations and aliases to use it.
- Adds a new example demonstrating simultaneous WiFi and Ethernet ArtNet send/receive.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| ArtnetETH.h | Adds ETHUdp type and updates specializations/aliases to avoid WiFi/Ethernet UDP type conflicts. |
| examples/Multiple/send_receive_eth/send_receive_eth.ino | New example showing concurrent WiFi and Ethernet ArtNet usage. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: