-
Notifications
You must be signed in to change notification settings - Fork 93
feat: added transaction lifecycle guide to documentation #870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
exploreriii
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow ! excellent work!
we have one issue - we don't yet have a get receipt method in the python sdk
currently executing it will also get you a receipt
|
Hi @CynthiaFotso please rebase to pull in main's changes, we applied a fix that was blocking our tests. |
|
Hi @CynthiaFotso please do let us know if we can be of assistance |
|
Hello, this is the Office Hour Bot. This is a reminder that the Hiero Python SDK Office Hours are scheduled in approximately 4 hours (14:00 UTC). This session provides an opportunity to ask questions regarding this Pull Request or receive assistance from a maintainer. Details:
Disclaimer: This is an automated reminder. Please verify the schedule here to be notified of any changes. |
|
Hi @CynthiaFotso , |
|
Hi @nadineloepfe |
d4aed96 to
a5fab62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds comprehensive beginner-friendly documentation explaining the transaction lifecycle in the Hedera Python SDK. The guide covers the essential five-step flow (construct → freeze → sign → execute → check receipt) with detailed explanations, code examples in both Pythonic and method chaining styles, and common pitfalls to avoid.
Key Changes
- Created
docs/sdk_developers/training/transaction_lifecycle.mdwith complete transaction lifecycle documentation - Added entry to CHANGELOG.md documenting the new training guide
- Includes practical code examples, flow diagrams, and ResponseCode failure examples
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| docs/sdk_developers/training/transaction_lifecycle.md | New comprehensive guide explaining transaction lifecycle with step-by-step walkthrough, code examples, common pitfalls, and best practices |
| CHANGELOG.md | Added changelog entry documenting the new transaction lifecycle training guide |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
a5fab62 to
d88ce32
Compare
|
@exploreriii |
|
Hi @CynthiaFotso thank you so much, could you take a look to update the copilot feedback please? |
Yes I did and I have already addressed those changes. |
exploreriii
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent contribution - really incredible work!
I would like to merge this
We have a new release, 0.1.10
This means your changelog entry is outdated
Please pull in recent changes and rebase
and move this:
- Added
docs/sdk_developers/training/transaction_lifecycle.mdto explain the typical lifecycle of executing a transaction using the Hedera Python SDK.
rouhgly to line 11 or so
Signed-off-by: Cynthia Fotso <cynthiafotso8@gmail.com>
Signed-off-by: Cynthia Fotso <cynthiafotso8@gmail.com>
Signed-off-by: Cynthia Fotso <cynthiafotso8@gmail.com>
Signed-off-by: Cynthia Fotso <cynthiafotso8@gmail.com>
Signed-off-by: Cynthia Fotso <cynthiafotso8@gmail.com>
Signed-off-by: Cynthia Fotso <cynthiafotso8@gmail.com>
d88ce32 to
8b0de11
Compare
|
@exploreriii |
Description
This PR adds a beginner-friendly documentation page explaining the transaction lifecycle in the Python SDK.
Linked Issue
Fixes #864: Create docs/sdk_developers/training/transaction_lifecycle.md
Checklist
Created docs/sdk_developers/training/transaction_lifecycle.md
Overview of the transaction flow (construct → freeze → sign → execute → check receipt)
Detailed explanation of each step, including why the order matters
Code examples using both Pythonic and method chaining syntax
A simple flow diagram
Common pitfalls and best practices
Referenced existing examples like examples/token_grant_kyc.py and examples/token_associate.py