Skip to content

Conversation

@Om7035
Copy link
Contributor

@Om7035 Om7035 commented Nov 29, 2025

Description

This PR updates the __str__ method of the TokenInfo class to include all available token fields in its string representation. Previously, several important fields such as custom_fees, various keys (admin, kyc, freeze, etc.), and status flags were missing from the output, making debugging and logging less informative.

The following fields have been added to the __str__ output:

  • custom_fees
  • All keys: admin_key, kyc_key, freeze_key, wipe_key, supply_key, metadata_key, fee_schedule_key, pause_key
  • Statuses: default_freeze_status, default_kyc_status, pause_status
  • Auto-renew details: auto_renew_account, auto_renew_period
  • expiry
  • supply_type

Related Issue

Fixes #914

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation (if applicable).
  • I have updated the CHANGELOG.md under the [Unreleased] section.
  • My changes generate no new warnings.
  • I have signed my commits (GPG + DCO).

Signed-off-by: Om7035 <speedtech602@gmail.com>
@github-actions
Copy link

Hi, this is WorkflowBot.
Your pull request cannot be merged as it is not passing all our workflow checks.
Please click on each check to review the logs and resolve issues so all checks pass.
To help you:

@Om7035
Copy link
Contributor Author

Om7035 commented Nov 29, 2025

@exploreriii need your help
I'm encountering a persistent issue with the PR Formatting / Changelog Check workflow. Despite adding a new entry under the [Unreleased] section in CHANGELOG.md (as seen in the latest commits), the check continues to fail with "No line-level additions detected".

I have:

  • Verified the entry is under ## [Unreleased].
  • Ensured it is a new line with a bullet point.
  • Tried re-formatting and amending the commit.
  • Verified the diff locally shows the added lines.

This same behavior has occurred on another recent PR (#927) of mine as well. Could you please take a look? It seems like the workflow might not be picking up the changes correctly or there might be a subtle formatting requirement I'm missing.

@exploreriii
Copy link
Contributor

Hi @Om7035 sincere apologies for that, we are aware of the bug and are implementing a fix

@Om7035
Copy link
Contributor Author

Om7035 commented Nov 29, 2025

Hi @Om7035 sincere apologies for that, we are aware of the bug and are implementing a fix

Thanks @exploreriii its been resolved
can you check both the PRs i have made

@exploreriii
Copy link
Contributor

just merged the fix, thanks for rebasing so the recent changes apply, looks positive for now!

@Om7035
Copy link
Contributor Author

Om7035 commented Nov 29, 2025

@exploreriii how can I contact you on discord?

@exploreriii
Copy link
Contributor

My details are noted in /MAINTAINERS.md, you can also read docs/discord.md

Copy link
Contributor

@exploreriii exploreriii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Om7035
Please be sure to update the unit and integration tests with your new functionality.

You'll need to:
Review existing unit and integration tests for token info.
Update all instances that are checking string representation
For example:
tests/unit/test_token_info.py::test_str_representation
Ensure it includes all the new fields

This is why your workflows are failing

Scan to the bottom of the integration and unit test sections and see the full error messagae
https://github.com/hiero-ledger/hiero-sdk-python/actions/runs/19788607213/job/56698609176?pr=928

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

Hello, this is the Office Hour Bot.

This is a reminder that the Hiero Python SDK Office Hours are scheduled in approximately 4 hours (14:00 UTC).

This session provides an opportunity to ask questions regarding this Pull Request or receive assistance from a maintainer.

Details:

Disclaimer: This is an automated reminder. Please verify the schedule here to be notified of any changes.

@exploreriii
Copy link
Contributor

Closing PR as not assigned

@exploreriii exploreriii closed this Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update TokenInfo to dump all token fields

2 participants