-
Notifications
You must be signed in to change notification settings - Fork 93
feat: update TokenInfo to dump all token fields (#914) #928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Om7035 <speedtech602@gmail.com>
|
Hi, this is WorkflowBot.
|
|
@exploreriii need your help I have:
This same behavior has occurred on another recent PR (#927) of mine as well. Could you please take a look? It seems like the workflow might not be picking up the changes correctly or there might be a subtle formatting requirement I'm missing. |
|
Hi @Om7035 sincere apologies for that, we are aware of the bug and are implementing a fix |
Thanks @exploreriii its been resolved |
|
just merged the fix, thanks for rebasing so the recent changes apply, looks positive for now! |
|
@exploreriii how can I contact you on discord? |
|
My details are noted in /MAINTAINERS.md, you can also read docs/discord.md |
exploreriii
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Om7035
Please be sure to update the unit and integration tests with your new functionality.
You'll need to:
Review existing unit and integration tests for token info.
Update all instances that are checking string representation
For example:
tests/unit/test_token_info.py::test_str_representation
Ensure it includes all the new fields
This is why your workflows are failing
Scan to the bottom of the integration and unit test sections and see the full error messagae
https://github.com/hiero-ledger/hiero-sdk-python/actions/runs/19788607213/job/56698609176?pr=928
|
Hello, this is the Office Hour Bot. This is a reminder that the Hiero Python SDK Office Hours are scheduled in approximately 4 hours (14:00 UTC). This session provides an opportunity to ask questions regarding this Pull Request or receive assistance from a maintainer. Details:
Disclaimer: This is an automated reminder. Please verify the schedule here to be notified of any changes. |
|
Closing PR as not assigned |
Description
This PR updates the
__str__method of theTokenInfoclass to include all available token fields in its string representation. Previously, several important fields such ascustom_fees, various keys (admin, kyc, freeze, etc.), and status flags were missing from the output, making debugging and logging less informative.The following fields have been added to the
__str__output:custom_feesadmin_key,kyc_key,freeze_key,wipe_key,supply_key,metadata_key,fee_schedule_key,pause_keydefault_freeze_status,default_kyc_status,pause_statusauto_renew_account,auto_renew_periodexpirysupply_typeRelated Issue
Fixes #914
Type of Change
Checklist
CHANGELOG.mdunder the[Unreleased]section.