Skip to content

Add support for setting the locking behavior when opening file#114

Open
mgeplf wants to merge 2 commits intohighfive-devs:mainfrom
mgeplf:add-locks
Open

Add support for setting the locking behavior when opening file#114
mgeplf wants to merge 2 commits intohighfive-devs:mainfrom
mgeplf:add-locks

Conversation

@mgeplf
Copy link
Copy Markdown

@mgeplf mgeplf commented Apr 7, 2026

  • useful when on a shared filesystem that limits the number of locks, and files are only being read

* useful when on a shared filesystem that limits the number of locks, and files are only being read
@1uc
Copy link
Copy Markdown
Contributor

1uc commented Apr 12, 2026

Thank you, that looks like a nice feature. You can fix the formatting by running bin/format.sh. (Delete the venv if it complains.)

Do you understand why CI says it's not working? Plus you should be a dev now, so you can run CI. Sorry about the delay.

@mgeplf
Copy link
Copy Markdown
Author

mgeplf commented Apr 13, 2026

Do you understand why CI says it's not working?

I'll have a look and try and figure it out - I confess to not having looked at the CI on this repo before.

Plus you should be a dev now, so you can run CI. Sorry about the delay.

Neat, thanks. No worries, I'm not in a rush.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 15, 2026

Codecov Report

❌ Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
include/highfive/bits/h5p_wrapper.hpp 80.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants