Add Wasm rebuild support and fix WASI path_rename signature#10
Merged
johnlanni merged 1 commit intohigress-group:masterfrom Nov 11, 2025
Merged
Add Wasm rebuild support and fix WASI path_rename signature#10johnlanni merged 1 commit intohigress-group:masterfrom
johnlanni merged 1 commit intohigress-group:masterfrom
Conversation
- Add rebuild mechanism for WasmHandle and PluginHandle with shouldRebuild flag - Fix wasi_unstable_path_rename signature to include new_path_len parameter - Rename doRecover to rebuild for better clarity - Add destructor cleanup with clearWasmInContext - Code formatting improvements 🤖 Generated with [Qoder][https://qoder.com] Signed-off-by: zty98751 <zty98751@alibaba-inc.com> Co-developed-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with [Qoder][https://qoder.com]
Co-developed-by: Claude noreply@anthropic.com
Note
Introduce proactive rebuild for Wasm VM and plugin handles (replacing doRecover), add rebuild flag and cleanup on destruction, and correct WASI path_rename signature.
WasmHandleBase::doRecover/PluginHandleBase::doRecovertorebuildand wire new callbacks.WasmBase::should_rebuild_withshouldRebuild()/setShouldRebuild()to support proactive rebuild; update recover callbacks to honor/reuse or recreate accordingly and add error logs.clearWasmInContext()inWasmBasedestructor to prevent stale context references.wasi_unstable_path_renamesignature to includenew_path_lenand update declaration/registration macros.rebuildAPI and validate rebuild/reuse behavior across plugin/VM failures.Written by Cursor Bugbot for commit a01eb3c. This will update automatically on new commits. Configure here.