Time window の判定処理を修正した#8
Open
moba1 wants to merge 1 commit intohinananoha:mainfrom
Open
Conversation
moba1
force-pushed
the
bugfix/fix-time-window
branch
2 times, most recently
from
07cf74f to
0777c96
Compare
moba1
force-pushed
the
bugfix/fix-time-window
branch
from
0777c96 to
6c52c45
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
目的
time window の処理があまり厳格ではなったため、 time window の処理を厳密にした
詳細
Time window を表すクラスを作成し、そのクラスのインスタンスに time window 内にあるかを判定できるように処理を移譲した