Skip to content

Add GitHub Actions CI workflow for automated testing#2

Merged
hironow merged 4 commits intoclaude/repository-review-011CUsBS7PV1QYJsZBneF8ZRfrom
copilot/sub-pr-1
Nov 11, 2025
Merged

Add GitHub Actions CI workflow for automated testing#2
hironow merged 4 commits intoclaude/repository-review-011CUsBS7PV1QYJsZBneF8ZRfrom
copilot/sub-pr-1

Conversation

Copy link
Contributor

Copilot AI commented Nov 11, 2025

Added CI pipeline for the PyGMT nanobind benchmark implementation per maintainer request.

Workflow configuration (.github/workflows/test.yml):

  • Test matrix: Python 3.11/3.12/3.13/3.14 on Ubuntu
  • System deps: GMT library, Ghostscript, CMake, build-essential
  • Package manager: uv for fast dependency resolution
  • Test runner: pytest with verbose output and failure artifacts
  • Code quality: ruff (format/lint) and mypy type checking in separate job

Triggers: Push to main/copilot branches, PRs to main

README update: Added CI status badge

Project configuration (pyproject.toml):

  • Minimum Python version: 3.11
  • Classifiers for Python 3.11, 3.12, 3.13, and 3.14
  • Ruff and mypy target versions: Python 3.11

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI self-assigned this Nov 11, 2025
Co-authored-by: hironow <1401816+hironow@users.noreply.github.com>
Copilot AI changed the title [WIP] Introduce PyGMT nanobind benchmark for performance improvement Add GitHub Actions CI workflow for automated testing Nov 11, 2025
Copilot AI requested a review from hironow November 11, 2025 05:32
fail-fast: false
matrix:
os: [ubuntu-latest]
python-version: ['3.11', '3.12']
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot plz add 3.13, 3.14 & drop 3.11

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in commit 8409a38:

  • Test matrix now includes Python 3.12, 3.13, and 3.14
  • Removed Python 3.11
  • Updated pyproject.toml to reflect new minimum version (>=3.12) and classifiers
  • Updated ruff and mypy target versions to 3.12

@hironow
Copy link
Owner

hironow commented Nov 11, 2025

@copilot plz check pr comments

Co-authored-by: hironow <1401816+hironow@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Nov 11, 2025

@copilot plz check pr comments

I've reviewed all PR comments. The only review comment (regarding Python versions) has been addressed in commit 8409a38. All changes are complete:

  • ✅ Python 3.13 and 3.14 added to test matrix
  • ✅ Python 3.11 removed
  • ✅ pyproject.toml updated accordingly

No other actionable comments found.

@hironow
Copy link
Owner

hironow commented Nov 11, 2025

@copilot plz revert "drop 3.11"

Co-authored-by: hironow <1401816+hironow@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Nov 11, 2025

@copilot plz revert "drop 3.11"

Reverted in commit 5f72f5b. Python 3.11 has been added back:

  • Test matrix now includes: 3.11, 3.12, 3.13, and 3.14
  • pyproject.toml updated to support >=3.11
  • All tool configurations reverted to target Python 3.11

@hironow hironow marked this pull request as ready for review November 11, 2025 05:47
@hironow hironow merged commit 2cb7bf2 into claude/repository-review-011CUsBS7PV1QYJsZBneF8ZR Nov 11, 2025
@hironow hironow deleted the copilot/sub-pr-1 branch November 11, 2025 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants