feat: Implemented validators for Stacks signer message predicates with comprehensive passing tests#738
Open
Marvy247 wants to merge 1 commit intohirosystems:developfrom
Open
feat: Implemented validators for Stacks signer message predicates with comprehensive passing tests#738Marvy247 wants to merge 1 commit intohirosystems:developfrom
Marvy247 wants to merge 1 commit intohirosystems:developfrom
Conversation
Marvy247
commented
Jan 8, 2026
Marvy247
commented
- Add validation for StacksSignerMessagePredicate with pubkey and timestamp checks
- Validate secp256k1 public keys (compressed 33 bytes, uncompressed 65 bytes)
- Validate timestamps are non-zero and before year 2100
- Implement pubkey evaluation in evaluate_stacks_predicate_on_non_consensus_events
- Add comprehensive test suite covering valid/invalid pubkeys and timestamps
- Resolve TODOs for signer message predicate validation and evaluation
This change improves security by preventing invalid signer public keys
and timestamps from entering the system during predicate validation.
Author
1 similar comment
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.