Open
Conversation
|
Vercel deployment URL: https://stacks-blockchain-d4cix9gjs-hirosystems.vercel.app 🚀 |
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
He1DAr
force-pushed
the
feat/tx-type-filter
branch
from
379f278 to
d983942
Compare
rafaelcr
reviewed
Jul 23, 2025
| exports.up = pgm => { | ||
| pgm.createIndex('txs', 'status', { | ||
| where: 'canonical = TRUE AND microblock_canonical = TRUE', | ||
| name: 'idx_txs_status_optimized' |
Collaborator
There was a problem hiding this comment.
No need to provide a name, node-pg-migrate will define one for you with the current standards we use
| exports.shorthands = undefined; | ||
|
|
||
| exports.up = pgm => { | ||
| pgm.createIndex('txs', 'status', { |
Collaborator
There was a problem hiding this comment.
Adding the index is great but I don't think it will help a lot especially for the success status, given that the vast majority of transactions are successful.
I'm worried that running the endpoint on mainnet will cause performance issues when it tries to calculate the COUNT(*) of records to show in the total. We'll need to run load test on this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We're planning to support filtering by tx type in Stacks explorer search. This PR aims to add a new filter
typeto allow user filtering txs by type.Type of Change
Checklist
npm run testpasses