Enable HomeLink and Autopark (Summon)#118
Open
virgilm wants to merge 5 commits intohjespers:masterfrom
Open
Conversation
TODO: wake up car before? - otherwise does not work TODO: replace hardcoded coordinates TODO: exception handling TODO: refactor code?
Asking for status wakes up the car, so the command always succeeds. Started some refactoring.
Moar refactoring. Fixed synchronization issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm sure this can be done better (like setting up and keeping a websocket alive for all commands) and this is missing pretty much all error handling (callbacks, etc.), but it works just fine for me.
Abort is not implemented yet, so Summon will stop just in case there is an obstacle in front or when stopped with the remote/handle touch.
Let me know if this is of interest to you, and I can fix some of these issues. My first JS ever, so bear with me :)