(HKA-66) Cache song search results to reduce repeated fetch#2
Open
hkalbertkim wants to merge 2 commits intomainfrom
Open
(HKA-66) Cache song search results to reduce repeated fetch#2hkalbertkim wants to merge 2 commits intomainfrom
hkalbertkim wants to merge 2 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an in-memory TTL cache to the
searchYouTubefunction inserver/src/services/youtube.ts. Repeated searches for the same query now return cached results instead of hitting the YouTube Data API again.Why
Every search triggers 2 YouTube API calls (search + video details). The YouTube API has a daily quota (10,000 units); each search+details pair costs ~101 units. Users often re-search the same terms. Caching eliminates redundant API calls, reduces latency, and preserves quota.
What changed
server/src/services/youtube.ts— Added:searchCache: aMap<string, CacheEntry>keyed by lowercased querygetCachedSearch(query): returns cached results if within TTL (5 min)setCachedSearch(query, results): stores results with timestamp; evicts oldest entry when cache exceeds 100 entriessearchYouTube()[search-cache] HIT/[search-cache] MISSHow to test
cd server && npm run devcurl 'http://localhost:4000/api/search?q=bohemian+rhapsody'[search-cache] MISS[search-cache] HITand response is instantMISS(TTL expired)Risks / rollback