All dockable windows are tabs. Undocked create a window for further docking.#4
Open
alexkoon wants to merge 1 commit intohkmoon:masterfrom
alexkoon:master
Open
All dockable windows are tabs. Undocked create a window for further docking.#4alexkoon wants to merge 1 commit intohkmoon:masterfrom alexkoon:master
alexkoon wants to merge 1 commit intohkmoon:masterfrom
alexkoon:master
Conversation
…ck panes. An undocked pane creates its own window where further windows can be docked. Allows an app to have multiple windows across monitors for example. Empty windows cleaned up. Bug fix for isTabbed in DockNode - not uses the TabbedProperty value.
Author
|
Hi - have you had a chance to look at this yet? Or any issues? |
Owner
|
Hi @alexkoon First of all, I am sorry for my laziness due to current projects. I could not take a look on your code. However, many people are using https://github.com/ClearControl/DockFX instead of my repo because it is now community project. Perhaps, you could have a look the latest codes there and check if there is something wrong compared to your modified codes. Thank you so much! |
|
if someone had time it would be good if someone could merge all the
various useful efforts people have made.
…------ Original Message ------
From: "HongKee Moon" <notifications@github.com>
To: "hkmoon/DockFX" <DockFX@noreply.github.com>
Cc: "Subscribed" <subscribed@noreply.github.com>
Sent: 17/01/2017 09:50:15
Subject: Re: [hkmoon/DockFX] All dockable windows are tabs. Undocked
create a window for further docking. (#4)
Hi @alexkoon <https://github.com/alexkoon>
First of all, I am sorry for my laziness due to current projects. I
could not take a look on your code.
Today, I had a chance to do that actually.
However, many people are using https://github.com/ClearControl/DockFX
instead of my repo because it is now community project. Perhaps, you
could have a look the latest codes there and check if there is
something wrong compared to your modified codes.
Thank you so much!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#4 (comment)>, or
mute the thread
<https://github.com/notifications/unsubscribe-auth/AEBVpMlV_d5orL1efxyvWH1B9T1RMcvpks5rTI7XgaJpZM4LJ-oE>.
|
Owner
|
@jasons2000 Someone sounds pointing at me. ;) |
Author
|
Thanks - I'll have a look over at the ClearControl branch. |
Owner
|
@alexkoon Sorry! I actually reverted whole merging process because github had some problems last week. I need more time to check it actually. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every window is now a tab on content pane for a consistent look in dock panes. An undocked pane creates its own window where further windows can be docked. Allows an app to have multiple windows across monitors for example. Empty windows cleaned up.
Bug fix for isTabbed in DockNode - not uses the TabbedProperty value.