feat: add pre-push hook for lint and typecheck validation (#290)#468
Open
NatashaAlker wants to merge 3 commits intomasterfrom
Open
feat: add pre-push hook for lint and typecheck validation (#290)#468NatashaAlker wants to merge 3 commits intomasterfrom
NatashaAlker wants to merge 3 commits intomasterfrom
Conversation
Add Husky pre-push git hook that runs lint and TypeScript checks before allowing a push, catching errors locally instead of waiting for CI. - Install husky@9.1.7 with prepare script for auto-setup - Add typecheck script (tsc --noEmit) to all 30 workspace packages - Rename turbo task from type-check to typecheck for consistency - Add typecheck CI job to test.yml mirroring the lint job - Create ticket documentation in docs/tickets/290/ Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…r level These rules were at warning level (Biome default), meaning they didn't cause a non-zero exit code and wouldn't block the pre-push hook. Promote to error so unused variables and parameters are caught before pushing. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
📝 WalkthroughWalkthroughAdds a Husky pre-push hook and workspace Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Dev as Developer (local)
participant Git as Local Git
participant Husky as Husky pre-push
participant Yarn as Yarn/TSC
participant Repo as Remote GitHub
participant CI as GitHub Actions (type-check job)
Dev->>Git: git push
Git->>Husky: run pre-push hook
Husky->>Yarn: yarn lint
Yarn-->>Husky: lint pass/fail
alt lint passes
Husky->>Yarn: yarn typecheck (turbo typecheck -> invokes tsc in workspaces)
Yarn-->>Husky: typecheck pass/fail
alt typecheck passes
Husky->>Git: allow push
Git->>Repo: push commits
Repo->>CI: trigger workflows (includes type-check job)
CI->>CI: setup Node, db:generate, npx turbo typecheck
CI-->>Repo: report status
else typecheck fails
Husky->>Git: block push
end
else lint fails
Husky->>Git: block push
end
Possibly related issues
Possibly related PRs
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: bee8b8d9-f4a8-4a90-a527-bc79be23c551
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (38)
.github/workflows/test.yml.husky/pre-pushapps/api/package.jsonapps/crons/package.jsonapps/postgres/package.jsonapps/web/package.jsonbiome.jsondocs/tickets/290/plan.mddocs/tickets/290/tasks.mddocs/tickets/290/ticket.mdlibs/account/package.jsonlibs/admin-pages/package.jsonlibs/api/package.jsonlibs/audit-log/package.jsonlibs/auth/package.jsonlibs/cloud-native-platform/package.jsonlibs/list-search-config/package.jsonlibs/list-types/administrative-court-daily-cause-list/package.jsonlibs/list-types/care-standards-tribunal-weekly-hearing-list/package.jsonlibs/list-types/civil-and-family-daily-cause-list/package.jsonlibs/list-types/common/package.jsonlibs/list-types/court-of-appeal-civil-daily-cause-list/package.jsonlibs/list-types/london-administrative-court-daily-cause-list/package.jsonlibs/list-types/rcj-standard-daily-cause-list/package.jsonlibs/location/package.jsonlibs/notification/package.jsonlibs/notifications/package.jsonlibs/pdf-generation/package.jsonlibs/public-pages/package.jsonlibs/publication/package.jsonlibs/redis/package.jsonlibs/simple-router/package.jsonlibs/subscriptions/package.jsonlibs/system-admin-pages/package.jsonlibs/verified-pages/package.jsonlibs/web-core/package.jsonpackage.jsonturbo.json
Comment on lines
+3
to
+7
| - [x] Add husky devDependency and prepare/type-check scripts to root package.json | ||
| - [x] Run yarn install to install husky | ||
| - [x] Initialize husky and create .husky/pre-push hook | ||
| - [x] Add type-check script to all 30 workspace package.json files | ||
| - [x] Verify yarn type-check passes across all packages |
Contributor
There was a problem hiding this comment.
Use typecheck consistently in the checklist.
Lines 3, 6, and 7 still reference type-check, but the implemented script name is typecheck. This makes the task log inaccurate.
✏️ Suggested doc fix
-- [x] Add husky devDependency and prepare/type-check scripts to root package.json
+- [x] Add husky devDependency and prepare/typecheck scripts to root package.json
...
-- [x] Add type-check script to all 30 workspace package.json files
-- [x] Verify yarn type-check passes across all packages
+- [x] Add typecheck script to all 30 workspace package.json files
+- [x] Verify yarn typecheck passes across all packages📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| - [x] Add husky devDependency and prepare/type-check scripts to root package.json | |
| - [x] Run yarn install to install husky | |
| - [x] Initialize husky and create .husky/pre-push hook | |
| - [x] Add type-check script to all 30 workspace package.json files | |
| - [x] Verify yarn type-check passes across all packages | |
| - [x] Add husky devDependency and prepare/typecheck scripts to root package.json | |
| - [x] Run yarn install to install husky | |
| - [x] Initialize husky and create .husky/pre-push hook | |
| - [x] Add typecheck script to all 30 workspace package.json files | |
| - [x] Verify yarn typecheck passes across all packages |
|
|
||
| ### Acceptance criteria | ||
|
|
||
| Make sure there is no lint and typescript error in code before pushing to Github. |
Contributor
There was a problem hiding this comment.
Tidy acceptance criterion capitalisation.
Line 16 should use TypeScript and GitHub for consistency and correctness.
✏️ Suggested wording
-Make sure there is no lint and typescript error in code before pushing to Github.
+Make sure there are no lint or TypeScript errors in code before pushing to GitHub.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| Make sure there is no lint and typescript error in code before pushing to Github. | |
| Make sure there are no lint or TypeScript errors in code before pushing to GitHub. |
🧰 Tools
🪛 LanguageTool
[uncategorized] ~16-~16: The official name of this software platform is spelled with a capital “H”.
Context: ...escript error in code before pushing to Github. ## Comments ### Comment by OgechiOke...
(GITHUB)
Comment on lines
11
to
15
| "scripts": { | ||
| "build": "tsc", | ||
| "dev": "tsc --watch" | ||
| "dev": "tsc --watch", | ||
| "typecheck": "tsc --noEmit" | ||
| }, |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Check if libs/audit-log has test files or formatting/linting needs
# Check for test files
fd -e test.ts -e spec.ts . libs/audit-log/
# Check for source files that would need linting
fd -e ts -e tsx . libs/audit-log/src/
# Check if other lib packages have these scripts
rg -A 15 '"scripts"' libs/*/package.json | grep -E '(test|format|lint)'Repository: hmcts/cath-service
Length of output: 6297
🏁 Script executed:
cat -n libs/audit-log/package.jsonRepository: hmcts/cath-service
Length of output: 540
Add missing scripts to package.json.
This library package is missing the required test, test:watch, format, lint, and lint:fix scripts. All peer library modules include these alongside the build and dev scripts. Add the following to the scripts section:
"test": "vitest run",
"test:watch": "vitest watch",
"format": "biome format --write .",
"lint": "biome check .",
"lint:fix": "biome check --write --unsafe ."
Contributor
🎭 Playwright E2E Test Results257 tests 257 ✅ 25m 26s ⏱️ Results for commit 422f8da. ♻️ This comment has been updated with latest results. |
alexbottenberg
approved these changes
Mar 26, 2026
The blob-ingestion-notifications E2E test was failing because the payload had empty courtLists, causing notification processing to fail silently. Updated the payload with realistic case data matching the reference data for court_id 9001. Also fixed processUserNotification to update the notification audit log to "Failed" when an error is thrown after log creation, preventing notifications from being stuck in "Pending" state. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
libs/notifications/src/notification/notification-service.ts (1)
155-157: Avoid completely silent fallback-update failures.At Line 156, swallowing the nested failure with an empty catch hides operational signals. Consider logging the secondary error at least once.
Suggested tweak
- if (notification) { - await updateNotificationStatus(notification.notificationId, "Failed", undefined, errorMessage).catch(() => {}); - } + if (notification) { + await updateNotificationStatus(notification.notificationId, "Failed", undefined, errorMessage).catch((updateError) => { + console.warn( + `Failed to update notification status for ${notification.notificationId}`, + updateError + ); + }); + }
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: a23f872e-8aeb-4b10-9613-c4ab42e87f47
📒 Files selected for processing (3)
e2e-tests/tests/api/blob-ingestion-notifications.spec.tslibs/notifications/src/notification/notification-service.test.tslibs/notifications/src/notification/notification-service.ts
|
alexbottenberg
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
yarn lint && yarn typecheckbefore allowing pushes, catching lint and TypeScript errors locally before CItypecheckscript (tsc --noEmit) to all 30+ workspace packages and atypecheckturbo tasknoUnusedVariablesandnoUnusedFunctionParametersrules from warning to error level so they block pushestype-checkCI job totest.ymlbetween lint and test jobs (existing lint job unchanged)Test plan
debuggerstatement → push blocked with Biome errornumber = "string") → push blocked with TypeScript errorCloses #290
🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Bug Fixes
Chores
Tests