Conversation
Codecov Report
@@ Coverage Diff @@
## master #276 +/- ##
===========================================
+ Coverage 73.98% 86.60% +12.62%
===========================================
Files 24 37 +13
Lines 419 672 +253
===========================================
+ Hits 310 582 +272
+ Misses 109 90 -19
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
5b25613 to
c3d5122
Compare
442f9b1 to
376cfc0
Compare
|
In general all the parameters are missing the types. I will look at this PR once all the types are strongly typed. Thanks. |
This is a JavaScript project, not a TypeScript one. Therefore, no strong typing. 😁 |
udaydenduluri33
left a comment
There was a problem hiding this comment.
Approving on the basis that existing functionality is not touched
socket.io is introduced as an additional enhancement which could be feature toggled from application
Very small tweak to return the user name rather than their ID in the response and case listing.
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/EUI-4128 ✅
DONEhttps://tools.hmcts.net/jira/browse/EUI-4131 ✅
DONEhttps://tools.hmcts.net/jira/browse/EUI-4135 ✅
DONEhttps://tools.hmcts.net/jira/browse/EUI-4137 ✅
DONE(All under https://tools.hmcts.net/jira/browse/EUI-2976)
Change description
Introduced socket.io to provide a mechanism for watching activity on a list of cases and indicating when a user is viewing or editing a given case. This mirrors the functionality already in the activity tracker but uses "sockets" (websockets or long polling, depending on the client configuration) and does away with the need for repeated polling.
Does this PR introduce a breaking change? (check one with "x")