This repository was archived by the owner on Apr 26, 2021. It is now read-only.
Open
Conversation
added 12 commits
July 26, 2018 15:53
…g performance testing
…g performance testing
…g performance testing
S2S update (CNP)
kapiljain786
requested review from
andrewfolga,
dwaynebailey,
mario-paniccia,
ngul,
nickinsitaram-hmcts and
tzarsmango
MSancaktutar
left a comment
MSancaktutar
left a comment
There was a problem hiding this comment.
Looks good to me, but for the Scala codes, better to have at least 1 more review and an approval.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before creating a pull request make sure that:
Please remove this line and everything above and fill the following sections:
JIRA link (if applicable)
Change description
Does this PR introduce a breaking change? (check one with "x")