Skip to content

FACT-2368 added datafix#858

Open
justiceia wants to merge 25 commits intomasterfrom
FACT-2368
Open

FACT-2368 added datafix#858
justiceia wants to merge 25 commits intomasterfrom
FACT-2368

Conversation

@justiceia
Copy link
Copy Markdown
Contributor

JIRA link (if applicable)

https://tools.hmcts.net/jira/browse/FACT-2368

Change description

this should just be datafixes for making sure court pages are still readable and correct once mce is removed
note not finished yet

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

@justiceia justiceia requested a review from a team as a code owner June 17, 2025 09:18
@justiceia justiceia requested a review from josh-uk June 17, 2025 09:18
@justiceia justiceia self-assigned this Jun 24, 2025
@justiceia justiceia changed the title FACT-2368 added partial datafix FACT-2368 adde datafix Jun 26, 2025
@justiceia justiceia changed the title FACT-2368 adde datafix FACT-2368 add datafix Jun 26, 2025
@justiceia justiceia changed the title FACT-2368 add datafix FACT-2368 added datafix Jun 26, 2025
@amstevenson
Copy link
Copy Markdown
Contributor

I would have expected https://github.com/hmcts/fact-api/blob/master/src/main/java/uk/gov/hmcts/dts/fact/html/sanitizer/OwaspHtmlSanitizer.java to be updated also to not allow any html tags. We can assume that the tinymce boxes will not allow it (potentially) but if they do, we likely want to change the logic to prevent all html. Correct me if I am wrong and we allow some. I don't think we would after this change as it would be text only

@justiceia
Copy link
Copy Markdown
Contributor Author

I would have expected https://github.com/hmcts/fact-api/blob/master/src/main/java/uk/gov/hmcts/dts/fact/html/sanitizer/OwaspHtmlSanitizer.java to be updated also to not allow any html tags. We can assume that the tinymce boxes will not allow it (potentially) but if they do, we likely want to change the logic to prevent all html. Correct me if I am wrong and we allow some. I don't think we would after this change as it would be text only

changed it now to not allow any html through

Copy link
Copy Markdown
Contributor

@josh-uk josh-uk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual testing needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants