PO-2597: Investigate annotation based permission validation#39
Open
Ben-Edwards-cgi wants to merge 10 commits intomasterfrom
Open
PO-2597: Investigate annotation based permission validation#39Ben-Edwards-cgi wants to merge 10 commits intomasterfrom
Ben-Edwards-cgi wants to merge 10 commits intomasterfrom
Conversation
# Conflicts: # build.gradle
Will be tested via github actions
RustyHMCTS
reviewed
Jan 14, 2026
| if (authentication instanceof JwtAuthenticationToken jwtAuth) { | ||
| String token = jwtAuth.getToken().getTokenValue(); | ||
| requestTemplate.header("Authorization", "Bearer " + token); | ||
| } else { |
Contributor
There was a problem hiding this comment.
Just wondered why this 'else' clause was removed?
Collaborator
Author
There was a problem hiding this comment.
I removed it as it does not tell us a huge amount in the logs, and I thought I added it apart of this change.
Happy to hear your thoughts as I have no objections to adding it back if you see there is value
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/PO-2597
Change description
Updated security setup
Does this PR introduce a breaking change? (check one with "x")