Skip to content

Update libraries#2277

Draft
iamfrankiemoran wants to merge 6 commits intomasterfrom
update-libraries
Draft

Update libraries#2277
iamfrankiemoran wants to merge 6 commits intomasterfrom
update-libraries

Conversation

@iamfrankiemoran
Copy link
Copy Markdown
Contributor

Jira link

  • N/A

Change description

  • opal-frontend-common-node-lib has been changed and improved
  • opal-frontend-common-ui-lib has been changed and improved

Testing done

  • Smoke/Functional working as expected
  • Unit tests broken until moj/home office update to v6.0.0 of govuk-frontend

Security Vulnerability Assessment

CVE Suppression: Are there any CVEs present in the codebase (either newly introduced or pre-existing) that are being intentionally suppressed or ignored by this commit?

  • Yes
  • No

Checklist

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)
  • Does this PR introduce a breaking change

… and clarify usage of yarn pack:local

chore(deps): update local package references in package.json and yarn.lock for common libraries
fix(tsconfig): correct paths for common node library type definitions
Copy link
Copy Markdown
Contributor

@Arnabsubedi233 Arnabsubedi233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants