Draft
Conversation
…es and improved output structure
…markdown processing
… functionality in defendant details
…d pre-populated fields
- Added actions and assertions for converting a company account to an individual account in the EditDefendantDetailsActions class. - Updated feature files to include scenarios for converting to an individual account and verifying pre-filled fields. - Enhanced AccountEnquiryFlow to support individual account conversion actions and assertions. - Modified selectors to accommodate new convert action links and text. - Updated step definitions to handle new steps for converting to an individual account. - Enhanced FinesAccConvertComponent to manage conversion logic for individual accounts. - Created a new interface for convert actions to streamline handling of conversion options. - Updated tests to cover new conversion scenarios and ensure proper navigation and state management.
…r non-debtor company to individual conversion
…service, and postgresql
…dant details component
...acc-defendant-details-defendant-tab/fines-acc-defendant-details-defendant-tab.component.html
Show resolved
Hide resolved
Arnabsubedi233
requested changes
Mar 17, 2026
louisbriggs
reviewed
Mar 18, 2026
src/app/flows/fines/fines-acc/fines-acc-convert/fines-acc-convert.component.ts
Show resolved
Hide resolved
.codex/skills/opal-frontend/opal-ticket-context/agents/openai.yaml
Outdated
Show resolved
Hide resolved
…or TDIA markdown processing" This reverts commit 4fe4182.
iamfrankiemoran
requested changes
Mar 23, 2026
Contributor
iamfrankiemoran
left a comment
iamfrankiemoran
left a comment
There was a problem hiding this comment.
Minor thoughts about moving some plain text to constant files
Comment on lines
+74
to
+94
| /** | ||
| * Returns the confirmation heading for the requested conversion target. | ||
| */ | ||
| public get headingText(): string { | ||
| if (this.routePartyType === this.partyTypes.INDIVIDUAL) { | ||
| return 'Are you sure you want to convert this account to an individual account?'; | ||
| } | ||
|
|
||
| return 'Are you sure you want to convert this account to a company account?'; | ||
| } | ||
|
|
||
| /** | ||
| * Returns the warning copy describing which source-specific fields will be removed. | ||
| */ | ||
| public get warningText(): string { | ||
| if (this.routePartyType === this.partyTypes.INDIVIDUAL) { | ||
| return 'Some information specific to company accounts, such as company name, will be removed.'; | ||
| } | ||
|
|
||
| return 'Certain data related to individual accounts, such as employment details, will be removed.'; | ||
| } |
Contributor
There was a problem hiding this comment.
Would we want this plain text in constant files where we could pass in company or individual and details?
Comment on lines
+28
to
+41
| return { | ||
| interactive: true, | ||
| label: 'Convert to an individual account', | ||
| partyType: FINES_ACC_PARTY_ADD_AMEND_CONVERT_PARTY_TYPES.INDIVIDUAL, | ||
| }; | ||
| } | ||
|
|
||
| return { | ||
| interactive: true, | ||
| label: 'Convert to a company account', | ||
| partyType: FINES_ACC_PARTY_ADD_AMEND_CONVERT_PARTY_TYPES.COMPANY, | ||
| }; | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Again, the label text. I wonder if that should be in a constant?
Contributor
There was a problem hiding this comment.
Or if we have two constants, one for the company and one for the individual that can be returned instead?
Comment on lines
+46
to
+53
| if (this.partyType === 'company') { | ||
| return 'Converted to a company account.'; | ||
| } | ||
|
|
||
| if (this.partyType === 'individual') { | ||
| return 'Converted to an individual account.'; | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Should this be in a constant?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira link
See PROJ-XXXXXX
Change description
Testing done
Security Vulnerability Assessment
CVE Suppression: Are there any CVEs present in the codebase (either newly introduced or pre-existing) that are being intentionally suppressed or ignored by this commit?
Checklist