PO-3438: Update the UserEntity to reflect changes to the DB schema Users table.#443
Open
RustyHMCTS wants to merge 1 commit intomasterfrom
Open
PO-3438: Update the UserEntity to reflect changes to the DB schema Users table.#443RustyHMCTS wants to merge 1 commit intomasterfrom
RustyHMCTS wants to merge 1 commit intomasterfrom
Conversation
RustyHMCTS
force-pushed
the
PO-3438-update-users
branch
from
2802b4e to
a97d285
Compare
…for User Management Tactical PO-3438: Update the UserEntity to reflect changes to the DB schema Users table.
RustyHMCTS
force-pushed
the
PO-3438-update-users
branch
from
a97d285 to
48215d5
Compare
| .saveAndFlush(UserEntity.builder() | ||
| .username(claimSet.getClaim(PREFERRED_USERNAME_CLAIM).toString()) | ||
| .status(UserStatus.CREATED) | ||
| .createdDate(LocalDateTime.now()) |
Contributor
There was a problem hiding this comment.
It would be nicer to wire in a Clock to this service, and use LocalDateTime.now(clock).
Then we can assert on the time in the unit test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does this PR introduce a breaking change?** (check one with "x")