generated from hmcts/spring-boot-template
-
Notifications
You must be signed in to change notification settings - Fork 2
Hdpi 3764 income expenditure backend #1568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
arun-hmcts
wants to merge
21
commits into
master
Choose a base branch
from
HDPI-3764-income-expenditure-backend
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
da327c6
HDPI-3764: Add regular income fields to household circumstances for d…
arun-hmcts 629c35a
HDPI-3764: Add shareIncomeExpenseDetails field to household circumsta…
arun-hmcts 1d274b1
HDPI-3764: Add universalCredit and ucApplicationDate fields to domain…
arun-hmcts c4fe9d6
HDPI-3764: Add universal credit amount and frequency columns to incom…
arun-hmcts 98f54f6
HDPI-3764: Rename universal credit income fields to universal credit …
arun-hmcts 44f7e66
Merge branch 'master' into HDPI-3764-income-expenditure-backend
arun-hmcts bf5d869
HDPI-3764: Rename migration from V070 to V071 to resolve conflict wit…
arun-hmcts 0fe6d06
HDPI-3764: Merge master into income-expenditure-backend branch
arun-hmcts c361ead
HDPI-3764: Remove unnecessary comments from code
arun-hmcts 0ea2c58
HDPI-3764: Merge master into income-expenditure-backend branch
arun-hmcts 9248269
HDPI-3764: Add mapping for all income fields in HouseholdCircumstance…
arun-hmcts b07d3b7
HDPI-3764: Merge master into income-expenditure-backend branch
arun-hmcts 45b8178
HDPI-3764: Merge master into income-expenditure-backend branch
arun-hmcts fec7781
HDPI-3764: Renumber income migration from V071 to V072 due to master …
arun-hmcts 1c41ee7
HDPI-3764: Address peer review comments - add validation, consolidate…
arun-hmcts 06e33a2
HDPI-3764: Convert income frequency fields from String to enum
arun-hmcts 05b1916
HDPI-3764: Further reduce VARCHAR size from 10 to 5 for frequency col…
arun-hmcts 9be81e1
HDPI-3764: Revert VARCHAR size to 10 for frequency columns
arun-hmcts cc99802
HDPI-3764: Change enum values from WEEK/MONTH to WEEKLY/MONTHLY
arun-hmcts 97e22b7
HDPI-3764: Merge master into income-expenditure-backend branch
arun-hmcts c61c08c
HDPI-3764: Renumber migration V072 to V073 to resolve conflict after …
arun-hmcts File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
22 changes: 22 additions & 0 deletions
22
src/main/java/uk/gov/hmcts/reform/pcs/ccd/domain/IncomeFrequency.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| package uk.gov.hmcts.reform.pcs.ccd.domain; | ||
|
|
||
| import uk.gov.hmcts.ccd.sdk.api.HasLabel; | ||
|
|
||
| /** | ||
| * Enum representing the frequency of income and benefit payments. | ||
| */ | ||
| public enum IncomeFrequency implements HasLabel { | ||
| WEEKLY("Weekly"), | ||
| MONTHLY("Monthly"); | ||
|
|
||
| private final String label; | ||
|
|
||
| IncomeFrequency(String label) { | ||
| this.label = label; | ||
| } | ||
|
|
||
| @Override | ||
| public String getLabel() { | ||
| return label; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 14 additions & 0 deletions
14
src/main/resources/db/migration/V073__add_regular_income_fields.sql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| ALTER TABLE household_circumstances | ||
| ADD COLUMN income_from_jobs YES_NO, | ||
| ADD COLUMN income_from_jobs_amount DECIMAL(18,2), | ||
| ADD COLUMN income_from_jobs_frequency VARCHAR(10), | ||
| ADD COLUMN pension YES_NO, | ||
| ADD COLUMN pension_amount DECIMAL(18,2), | ||
| ADD COLUMN pension_frequency VARCHAR(10), | ||
| ADD COLUMN universal_credit_amount DECIMAL(18,2), | ||
| ADD COLUMN universal_credit_frequency VARCHAR(10), | ||
| ADD COLUMN other_benefits YES_NO, | ||
| ADD COLUMN other_benefits_amount DECIMAL(18,2), | ||
| ADD COLUMN other_benefits_frequency VARCHAR(10), | ||
| ADD COLUMN money_from_elsewhere YES_NO, | ||
| ADD COLUMN money_from_elsewhere_details VARCHAR(500); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe rename the enum to just 'Frequency' or something more generic? so this enum can be used for both the
regular incomeandregular expenses.