HDPI-4054 Adding caseManagementLocation as top level field by SachinPNaikHMCTS · Pull Request #1570 · hmcts/pcs-api

SachinPNaikHMCTS · 2026-03-24T21:51:49Z

Jira link

Change description

Testing done

Security Vulnerability Assessment

CVE Suppression: Are there any CVEs present in the codebase (either newly introduced or pre-existing) that are being intentionally suppressed or ignored by this commit?

Yes
No

Checklist

commit messages are meaningful and follow good commit message guidelines
README and other documentation has been updated / added (if needed)
tests have been updated / new tests has been added (if needed)
Does this PR introduce a breaking change

github-actions · 2026-03-24T21:54:56Z

CCD diff summary

👉 Full report: https://github.com/hmcts/pcs-api/actions/runs/23590769287?check_suite_focus=true

CaseField.json

RegularExpression	Max	Searchable	Min	FieldTypeParameter	HintText	Label	ID	FieldType
+	+	+	+	+	+	+CaseManagementLocation	+caseManagementLocationFormatted	+Text
+	+	+	+	+	+	+Region Id	+regionId	+Number

AuthorisationCaseField/caseworker-pcs.json

UserRole	CaseFieldID	CRUD
+caseworker-pcs	+caseManagementLocationFormatted	+CRUD

AuthorisationCaseField/caseworker-pcs-solicitor.json

UserRole	CaseFieldID	CRUD
+caseworker-pcs-solicitor	+caseManagementLocationFormatted	+CRUD

tvr-hmcts

Some thoughts.

Please check the formatting on the classes also.

src/main/java/uk/gov/hmcts/reform/pcs/ccd/view/globalsearch/CaseManagementLocationView.java

tvr-hmcts · 2026-03-24T23:40:23Z

src/main/java/uk/gov/hmcts/reform/pcs/ccd/view/globalsearch/CaseManagementLocationView.java

+
+@Component
+@AllArgsConstructor
+@Slf4j


src/main/java/uk/gov/hmcts/reform/pcs/ccd/view/globalsearch/CaseManagementLocationView.java

tvr-hmcts · 2026-03-24T23:57:28Z

src/main/java/uk/gov/hmcts/reform/pcs/ccd/view/globalsearch/CaseNameHmctsView.java

-                                                          claimant.getValue().getLastName())
-                                             .orElse(null));
+                    .findFirst()
+                    .map(ListValue<Party>::getValue)


can be interred. Ok to keep if it helps others though I guess.

It was done as part of review. #1496 (comment)

Sorry ... typo ... I meant 'infered' ... Kinesis split keyboard pain.

tvr-hmcts · 2026-03-24T23:58:26Z

src/test/java/uk/gov/hmcts/reform/pcs/ccd/PCSCaseViewTest.java

-    private CaseNameHmctsFormatter caseNameHmctsFormatter;
+    private CaseNameHmctsView caseNameHmctsView;
+    @Mock
+    CaseManagementLocationView caseManagementLocationView;


tvr-hmcts · 2026-03-24T23:59:28Z

src/main/java/uk/gov/hmcts/reform/pcs/ccd/view/globalsearch/CaseManagementLocationView.java

+    }
+
+
+    private String getFormattedValue(final Integer region, final Integer epimsId) {


final's not needed

tvr-hmcts · 2026-03-24T23:59:54Z

src/main/java/uk/gov/hmcts/reform/pcs/ccd/view/globalsearch/CaseManagementLocationView.java

+
+
+    private String getFormattedValue(final Integer region, final Integer epimsId) {
+        return String.format("{region:%s,baseLocation:%s}", region, epimsId);


Not sure on this approach. Suspect it maybe fragile.

Sorry I didn't catch that?

return "{region:%s,baseLocation:%s}".formatted(region, epimsId);

src/main/java/uk/gov/hmcts/reform/pcs/ccd/domain/PCSCase.java

scottstewart-sl · 2026-03-25T08:32:13Z

src/test/java/uk/gov/hmcts/reform/pcs/ccd/PCSCaseViewTest.java

+    @Test
+    void shouldSetCaseManagementLocationField() {
+        // When
+        doNothing().when(caseManagementLocationView).setCaseManagementLocationField(any(PCSCase.class));


Minor - why is this needed? Isn't that the default behaviour?

caseManagementLocationView is a Mock. So when setCaseManagementLocationField is called we wanted to inform mock to do nothing since its a void method.

scottstewart-sl · 2026-03-25T08:33:23Z

src/main/java/uk/gov/hmcts/reform/pcs/ccd/view/globalsearch/CaseManagementLocationView.java

+    }
+
+
+    private String getFormattedValue(final Integer region, final Integer epimsId) {


You know at this stage that the parameters are not null so you might as well make them primitive types.

hmcts-jenkins-j-to-z · 2026-03-25T16:28:15Z

Plan Result (aat)

No changes. Your infrastructure matches the configuration.

tvr-hmcts · 2026-03-25T16:50:06Z

src/main/java/uk/gov/hmcts/reform/pcs/ccd/view/globalsearch/CaseFieldsView.java

+     *
+     * @param pcsCase The current case data
+     */
+    public void setCaseManagementLocationField(final PCSCase pcsCase) {


No direct tests on this method. However I see it is only called internally so it should - private or tested

src/test/java/uk/gov/hmcts/reform/pcs/ccd/view/globalsearch/CaseFieldsViewTest.java

src/main/java/uk/gov/hmcts/reform/pcs/ccd/view/globalsearch/CaseFieldsView.java

tvr-hmcts

The refactoring helped :) Though there are still some elements that can be changed up a bit.

tvr-hmcts

Just these two. One a minor naming and the other a clarification as to what I meant in my earlier comment.

src/main/java/uk/gov/hmcts/reform/pcs/ccd/view/globalsearch/CaseFieldsView.java

src/test/java/uk/gov/hmcts/reform/pcs/ccd/view/globalsearch/CaseFieldsViewTest.java

spnaik77 added 2 commits March 24, 2026 21:15

HDPI-4054 Adding caseManagementLocation as top level field

8bc8c62

HDPI-4054 Adding caseManagementLocation as top level field

b478252

SachinPNaikHMCTS requested review from a team, aqibh25, arun-hmcts, saurabhvalsangkar-hmcts and tvr-hmcts March 24, 2026 21:51

SachinPNaikHMCTS added ns:pcs enable_keep_helm pr-values:ccd labels Mar 24, 2026

hmcts-jenkins-j-to-z bot requested a deployment to preview March 24, 2026 22:03 Abandoned

hmcts-jenkins-j-to-z bot requested a deployment to preview March 24, 2026 22:12 Abandoned

hmcts-jenkins-j-to-z bot requested a deployment to preview March 24, 2026 22:15 Abandoned

hmcts-jenkins-j-to-z bot requested a deployment to preview March 24, 2026 22:18 Abandoned

SachinPNaikHMCTS added the prd:pcs label Mar 24, 2026

hmcts-jenkins-j-to-z bot requested a deployment to preview March 24, 2026 22:39 Abandoned

tvr-hmcts reviewed Mar 25, 2026

View reviewed changes

scottstewart-sl requested changes Mar 25, 2026

View reviewed changes

scottstewart-sl reviewed Mar 25, 2026

View reviewed changes

hmcts-jenkins-j-to-z bot deployed to preview March 25, 2026 09:37 View deployment

hmcts-jenkins-j-to-z bot added the rel:pcs-api-pr-1570 label Mar 25, 2026

spnaik77 added 3 commits March 25, 2026 15:58

HDPI-4054 Adding caseManagementLocation as top level field

f6a9eda

HDPI-4054 Adding caseManagementLocation as top level field

a105147

HDPI-4054 Adding caseManagementLocation as top level field

bdab032

hmcts-jenkins-j-to-z bot added the aat/no-changes label Mar 25, 2026

hmcts-jenkins-j-to-z bot deployed to preview March 25, 2026 16:28 View deployment

hmcts-jenkins-j-to-z bot deployed to preview March 25, 2026 16:34 View deployment

scottstewart-sl approved these changes Mar 25, 2026

View reviewed changes

hmcts-jenkins-j-to-z bot deployed to preview March 25, 2026 17:02 View deployment

tvr-hmcts reviewed Mar 25, 2026

View reviewed changes

HDPI-4054 Adding caseManagementLocation as top level field

f9c8f62

hmcts-jenkins-j-to-z bot deployed to preview March 25, 2026 18:16 View deployment

HDPI-4054 Adding caseManagementLocation as top level field

2a48061

hmcts-jenkins-j-to-z bot deployed to preview March 25, 2026 18:39 View deployment

tvr-hmcts approved these changes Mar 25, 2026

View reviewed changes

src/main/java/uk/gov/hmcts/reform/pcs/ccd/view/globalsearch/CaseFieldsView.java Outdated Show resolved Hide resolved

src/test/java/uk/gov/hmcts/reform/pcs/ccd/view/globalsearch/CaseFieldsViewTest.java Outdated Show resolved Hide resolved

spnaik77 and others added 2 commits March 26, 2026 10:40

HDPI-4054 Adding caseManagementLocation as top level field

893c7ab

Merge branch 'master' into HDPI-4054-caseManagementLocation-b

2bd4826

hmcts-jenkins-j-to-z bot deployed to preview March 26, 2026 11:09 View deployment

toby-plunkett approved these changes Mar 26, 2026

View reviewed changes

hmcts-jenkins-j-to-z bot deployed to preview March 26, 2026 11:37 View deployment

		}


		private String getFormattedValue(final Integer region, final Integer epimsId) {



		private String getFormattedValue(final Integer region, final Integer epimsId) {
		return String.format("{region:%s,baseLocation:%s}", region, epimsId);

Conversation

SachinPNaikHMCTS commented Mar 24, 2026

Jira link

Change description

Testing done

Security Vulnerability Assessment

Checklist

Uh oh!

github-actions bot commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CCD diff summary

CaseField.json

AuthorisationCaseField/caseworker-pcs.json

AuthorisationCaseField/caseworker-pcs-solicitor.json

Uh oh!

tvr-hmcts left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hmcts-jenkins-j-to-z bot commented Mar 25, 2026

Plan Result (aat)

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tvr-hmcts left a comment

Choose a reason for hiding this comment

Uh oh!

tvr-hmcts left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

github-actions bot commented Mar 24, 2026 •

edited

Loading