HDPI-3566-situation-interstitial-dependants-pages#969
HDPI-3566-situation-interstitial-dependants-pages#969
Conversation
…ng in case user changes from yes to no in order to clear old value
…-interstitial-dependants-pages
…older page for routing to situation-interstitial
…ously locally even though incorrect casing but not on preview
…-interstitial-dependants-pages
src/main/assets/locales/cy/respondToClaim/doYouHaveAnyOtherDependants.json
Outdated
Show resolved
Hide resolved
src/main/steps/respond-to-claim/any-other-dependants/anyOtherDependants.njk
Outdated
Show resolved
Hide resolved
src/main/assets/locales/cy/respondToClaim/doYouHaveAnyOtherDependants.json
Outdated
Show resolved
Hide resolved
…itle to use html entities
…-interstitial-dependants-pages
…ion label bold as per design
| 'repayments-agreed': { | ||
| previousStep: 'repayments-made', | ||
| defaultNext: 'your-household-and-circumstances', | ||
| routes: [ |
There was a problem hiding this comment.
Minor: Could you have method and use it here in to have more cleaner and easy to read please
There was a problem hiding this comment.
@arun-hmcts Good spot, though I think this is a slightly different case, the condition is already a one-liner and unlike a function like isRentArrearsClaim, there's no real logic to encapsulate, just a value check. I've kept it inline as it follows the expected pattern for simple conditions like this.
There was a problem hiding this comment.
@arun-hmcts I've removed the types for the unused parameters so it doesn't spread over so many lines because of the linter e.g.
{ condition: async (_req, _formData, currentStepData: Record<string, unknown>) => currentStepData?.repaymentsAgreed === 'yes' || currentStepData?.repaymentsAgreed === 'imNotSure', nextStep: 'your-household-and-circumstances', },
Jira link
See HDPI-3566
Change description
-added three pages:
situation interstitial,dependant children,other dependants-refactored
repayments agreedplaceholder page slightly to add radio buttons and routing tosituation-interstitialbased on 'Yes' or 'I'm not sure' answers (full implementation forrepayments agreeddone in #924)-moved
Yes/No/I'm not suretype options to the common translations for reusabilityTesting done
-tested locally and all working as expected
Security Vulnerability Assessment
CVE Suppression: Are there any CVEs present in the codebase (either newly introduced or pre-existing) that are being intentionally suppressed or ignored by this commit?
Checklist