Skip to content

HDPI-3566-situation-interstitial-dependants-pages#969

Open
AlexBuzea wants to merge 23 commits intomasterfrom
HDPI-3566-situation-interstitial-dependants-pages
Open

HDPI-3566-situation-interstitial-dependants-pages#969
AlexBuzea wants to merge 23 commits intomasterfrom
HDPI-3566-situation-interstitial-dependants-pages

Conversation

@AlexBuzea
Copy link
Copy Markdown
Contributor

@AlexBuzea AlexBuzea commented Mar 19, 2026

Jira link

See HDPI-3566

Change description

-added three pages: situation interstitial, dependant children, other dependants
-refactored repayments agreed placeholder page slightly to add radio buttons and routing to situation-interstitial based on 'Yes' or 'I'm not sure' answers (full implementation for repayments agreed done in #924)
-moved Yes/No/I'm not sure type options to the common translations for reusability

image image image image

Testing done

-tested locally and all working as expected

Security Vulnerability Assessment

CVE Suppression: Are there any CVEs present in the codebase (either newly introduced or pre-existing) that are being intentionally suppressed or ignored by this commit?

  • Yes
  • No

Checklist

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)
  • Does this PR introduce a breaking change

…older page for routing to situation-interstitial
…ously locally even though incorrect casing but not on preview
@AlexBuzea AlexBuzea marked this pull request as ready for review March 26, 2026 10:39
'repayments-agreed': {
previousStep: 'repayments-made',
defaultNext: 'your-household-and-circumstances',
routes: [
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: Could you have method and use it here in to have more cleaner and easy to read please

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arun-hmcts Good spot, though I think this is a slightly different case, the condition is already a one-liner and unlike a function like isRentArrearsClaim, there's no real logic to encapsulate, just a value check. I've kept it inline as it follows the expected pattern for simple conditions like this.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arun-hmcts I've removed the types for the unused parameters so it doesn't spread over so many lines because of the linter e.g.
{ condition: async (_req, _formData, currentStepData: Record<string, unknown>) => currentStepData?.repaymentsAgreed === 'yes' || currentStepData?.repaymentsAgreed === 'imNotSure', nextStep: 'your-household-and-circumstances', },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants