Merged
Conversation
Contributor
Plan Result (stg)
Change Result (Click me) # azurerm_key_vault_secret.appinsights-key will be updated in-place
~ resource "azurerm_key_vault_secret" "appinsights-key" {
- expiration_date = "2026-06-01T01:00:00Z" -> null
id = "https://pre-hmctskv-stg.vault.azure.net/secrets/AppInsightsInstrumentationKey/3824fbfd9e37439f8a0c156c018cc549"
name = "AppInsightsInstrumentationKey"
tags = {}
# (9 unchanged attributes hidden)
}
# azurerm_key_vault_secret.appinsights_connection_string will be updated in-place
~ resource "azurerm_key_vault_secret" "appinsights_connection_string" {
- expiration_date = "2026-06-01T01:00:00Z" -> null
id = "https://pre-hmctskv-stg.vault.azure.net/secrets/app-insights-connection-string/2de0b698475e48dd8db173462d6a2a0d"
name = "app-insights-connection-string"
tags = {}
# (9 unchanged attributes hidden)
}
# azurerm_key_vault_secret.sa_storage_account_connection_string will be updated in-place
~ resource "azurerm_key_vault_secret" "sa_storage_account_connection_string" {
- expiration_date = "2026-06-01T01:00:00Z" -> null
id = "https://pre-hmctskv-stg.vault.azure.net/secrets/sa-storage-account-connection-string/0ebade2d395b4521bff89285049f9058"
name = "sa-storage-account-connection-string"
tags = {}
# (9 unchanged attributes hidden)
}
# azurerm_key_vault_secret.vodasa_storage_account_connection_string will be updated in-place
~ resource "azurerm_key_vault_secret" "vodasa_storage_account_connection_string" {
- expiration_date = "2026-06-01T01:00:00Z" -> null
id = "https://pre-hmctskv-stg.vault.azure.net/secrets/vodasa-storage-account-connection-string/68813fe6443341acb63b19542485dcae"
name = "vodasa-storage-account-connection-string"
tags = {}
# (9 unchanged attributes hidden)
}
# azurerm_key_vault_secret.vodasa_storage_account_primary_access_key will be updated in-place
~ resource "azurerm_key_vault_secret" "vodasa_storage_account_primary_access_key" {
- expiration_date = "2026-06-01T01:00:00Z" -> null
id = "https://pre-hmctskv-stg.vault.azure.net/secrets/vodasa-storage-account-primary-access-key/12b9920e922b4f498c20a84f77727575"
name = "vodasa-storage-account-primary-access-key"
tags = {}
# (9 unchanged attributes hidden)
}
# module.finalsa_storage_account.azurerm_storage_account.storage_account will be updated in-place
~ resource "azurerm_storage_account" "storage_account" {
id = "/subscriptions/74dacd4f-a248-45bb-a2f0-af700dc4cf68/resourceGroups/pre-stg/providers/Microsoft.Storage/storageAccounts/prefinalsastg"
name = "prefinalsastg"
tags = {
"application" = "pre-recorded-evidence"
"autoShutdown" = "true"
"builtFrom" = "https://github.com/HMCTS/pre-shared-infrastructure.git"
"businessArea" = "Cross-Cutting"
"contactSlackChannel" = "#dts-pre-rec-evidence-tech"
"environment" = "staging"
"managedBy" = "Pre Recorded Evidence"
}
# (97 unchanged attributes hidden)
+ network_rules {
+ bypass = [
+ "AzureServices",
]
+ default_action = "Allow"
}
# (3 unchanged blocks hidden)
}
# module.ingestsa_storage_account.azurerm_storage_account.storage_account will be updated in-place
~ resource "azurerm_storage_account" "storage_account" {
id = "/subscriptions/74dacd4f-a248-45bb-a2f0-af700dc4cf68/resourceGroups/pre-stg/providers/Microsoft.Storage/storageAccounts/preingestsastg"
name = "preingestsastg"
tags = {
"application" = "pre-recorded-evidence"
"autoShutdown" = "true"
"builtFrom" = "https://github.com/HMCTS/pre-shared-infrastructure.git"
"businessArea" = "Cross-Cutting"
"contactSlackChannel" = "#dts-pre-rec-evidence-tech"
"environment" = "staging"
"managedBy" = "Pre Recorded Evidence"
}
# (97 unchanged attributes hidden)
+ network_rules {
+ bypass = [
+ "AzureServices",
]
+ default_action = "Allow"
}
# (3 unchanged blocks hidden)
}
Plan: 0 to add, 7 to change, 0 to destroy. |
Contributor
Plan Result (prod)
Change Result (Click me) # azurerm_key_vault_secret.appinsights-key will be updated in-place
~ resource "azurerm_key_vault_secret" "appinsights-key" {
- expiration_date = "2026-06-01T01:00:00Z" -> null
id = "https://pre-hmctskv-prod.vault.azure.net/secrets/AppInsightsInstrumentationKey/3f0b5b0015844ecdab6c3712482dd017"
name = "AppInsightsInstrumentationKey"
tags = {}
# (9 unchanged attributes hidden)
}
# azurerm_key_vault_secret.appinsights_connection_string will be updated in-place
~ resource "azurerm_key_vault_secret" "appinsights_connection_string" {
- expiration_date = "2026-06-01T01:00:00Z" -> null
id = "https://pre-hmctskv-prod.vault.azure.net/secrets/app-insights-connection-string/6bcd095bf8684e48a86eb1d701fc4e9b"
name = "app-insights-connection-string"
tags = {}
# (9 unchanged attributes hidden)
}
# azurerm_key_vault_secret.sa_storage_account_connection_string will be updated in-place
~ resource "azurerm_key_vault_secret" "sa_storage_account_connection_string" {
- expiration_date = "2026-06-01T01:00:00Z" -> null
id = "https://pre-hmctskv-prod.vault.azure.net/secrets/sa-storage-account-connection-string/54fa132345714daea67251a1f1c32d97"
name = "sa-storage-account-connection-string"
tags = {}
# (9 unchanged attributes hidden)
}
# azurerm_key_vault_secret.vodasa_storage_account_connection_string will be updated in-place
~ resource "azurerm_key_vault_secret" "vodasa_storage_account_connection_string" {
- expiration_date = "2026-06-01T01:00:00Z" -> null
id = "https://pre-hmctskv-prod.vault.azure.net/secrets/vodasa-storage-account-connection-string/432370f5d99d47068e93f0e9e0e0fda4"
name = "vodasa-storage-account-connection-string"
tags = {}
# (9 unchanged attributes hidden)
}
# azurerm_key_vault_secret.vodasa_storage_account_primary_access_key will be updated in-place
~ resource "azurerm_key_vault_secret" "vodasa_storage_account_primary_access_key" {
- expiration_date = "2026-06-01T01:00:00Z" -> null
id = "https://pre-hmctskv-prod.vault.azure.net/secrets/vodasa-storage-account-primary-access-key/4550b7d2873a4fc3963b0628b5366412"
name = "vodasa-storage-account-primary-access-key"
tags = {}
# (9 unchanged attributes hidden)
}
# azurerm_monitor_metric_alert.storage_final_alert_capacity[0] will be updated in-place
~ resource "azurerm_monitor_metric_alert" "storage_final_alert_capacity" {
id = "/subscriptions/5ca62022-6aa2-4cee-aaa7-e7536c8d566c/resourceGroups/pre-prod/providers/Microsoft.Insights/metricAlerts/used_capacity"
name = "used_capacity"
~ scopes = [
- "/subscriptions/5ca62022-6aa2-4cee-aaa7-e7536c8d566c/resourceGroups/pre-prod/providers/Microsoft.Storage/storageAccounts/preingestsaprod",
+ "/subscriptions/5ca62022-6aa2-4cee-aaa7-e7536c8d566c/resourceGroups/pre-prod/providers/Microsoft.Storage/storageAccounts/prefinalsaprod",
]
tags = {
"application" = "pre-recorded-evidence"
"builtFrom" = "https://github.com/HMCTS/pre-shared-infrastructure.git"
"businessArea" = "Cross-Cutting"
"contactSlackChannel" = "#dts-pre-rec-evidence-tech"
"environment" = "production"
"managedBy" = "Pre Recorded Evidence"
}
# (9 unchanged attributes hidden)
# (2 unchanged blocks hidden)
}
# module.finalsa_storage_account.azurerm_storage_account.storage_account will be updated in-place
~ resource "azurerm_storage_account" "storage_account" {
id = "/subscriptions/5ca62022-6aa2-4cee-aaa7-e7536c8d566c/resourceGroups/pre-prod/providers/Microsoft.Storage/storageAccounts/prefinalsaprod"
name = "prefinalsaprod"
tags = {
"application" = "pre-recorded-evidence"
"builtFrom" = "https://github.com/HMCTS/pre-shared-infrastructure.git"
"businessArea" = "Cross-Cutting"
"contactSlackChannel" = "#dts-pre-rec-evidence-tech"
"environment" = "production"
"managedBy" = "Pre Recorded Evidence"
}
# (97 unchanged attributes hidden)
+ network_rules {
+ bypass = [
+ "AzureServices",
]
+ default_action = "Allow"
}
# (3 unchanged blocks hidden)
}
# module.ingestsa_storage_account.azurerm_storage_account.storage_account will be updated in-place
~ resource "azurerm_storage_account" "storage_account" {
id = "/subscriptions/5ca62022-6aa2-4cee-aaa7-e7536c8d566c/resourceGroups/pre-prod/providers/Microsoft.Storage/storageAccounts/preingestsaprod"
name = "preingestsaprod"
tags = {
"application" = "pre-recorded-evidence"
"builtFrom" = "https://github.com/HMCTS/pre-shared-infrastructure.git"
"businessArea" = "Cross-Cutting"
"contactSlackChannel" = "#dts-pre-rec-evidence-tech"
"environment" = "production"
"managedBy" = "Pre Recorded Evidence"
}
# (97 unchanged attributes hidden)
+ network_rules {
+ bypass = [
+ "AzureServices",
]
+ default_action = "Allow"
}
# (3 unchanged blocks hidden)
}
Plan: 0 to add, 8 to change, 0 to destroy. |
lydiaralphgov
approved these changes
Dec 5, 2025
Contributor
lydiaralphgov
left a comment
lydiaralphgov
left a comment
There was a problem hiding this comment.
I don't claim to be an expert on B2C but it looks sensible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.