Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/FPVTL-1845
Change description
This fixes a timeout issue whenever the "service-request-update" endpoint in cos-api was called. When this call comes in we currently do loads of case data updates before sending back a response. Sometimes this could take 3 seconds, by which time the calling service would timeout and give up but they would keep trying until we send them a 200.
This PR sends back a 200 immediately - an ack basically - because the calling api doesn't care what we do with the data. Once this response is sent an asynchronous thread is launched which does all the heavy lifting in the background.
Does this PR introduce a breaking change? (check one with "x")