Skip to content

CME-285: pact tests #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
AntonyLeons wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

CME-285: pact tests #442

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68cfec5
fix(pacts): correct content-type headers in pact files
AntonyLeons Aug 27, 2025
e33a365
Remove strict Content-Type header matching from PACT contracts to fix…
AntonyLeons Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@
!gradle/wrapper/gradle-wrapper.jar
*.class
bin/main/application.yaml
bin/contractTest/
bin/functionalTest/
bin/integrationTest/
bin/main/
bin/test/

### STS ###
.apt_generated
Expand Down
36 changes: 2 additions & 34 deletions pacts/prl-dgs-api-CCD_CASE_DOCS_AM_API.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,23 +17,7 @@
}
},
"response": {
"status": 200,
"headers": {
"Content-Type": "application/vnd\u63AFuk\u98E0gov\u8E83hmcts\uED68dm\u347Adocument\u7C16v1haljson;charset=UTF-8"
},
"matchingRules": {
"header": {
"Content-Type": {
"matchers": [
{
"match": "regex",
"regex": "application/vnd.uk.gov.hmcts.dm.document.v1+hal+json;charset=UTF-8"
}
],
"combine": "AND"
}
}
}
"status": 200
},
"providerStates": [
{
Expand All @@ -51,23 +35,7 @@
}
},
"response": {
"status": 500,
"headers": {
"Content-Type": "application/vnd\uF5A0uk\uE1D7gov\u0205hmcts\u0E15dm\uCDCDdocument\u0B01v111haljson;charset=UTF-8"
},
"matchingRules": {
"header": {
"Content-Type": {
"matchers": [
{
"match": "regex",
"regex": "application/vnd.uk.gov.hmcts.dm.document.v1+hal+json;charset=UTF-8"
}
],
"combine": "AND"
}
}
}
"status": 500
},
"providerStates": [
{
Expand Down
10 changes: 0 additions & 10 deletions src/contractTest/java/uk/gov/hmcts/reform/prl/documentgenerator/CdamApiConsumerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package uk.gov.hmcts.reform.prl.documentgenerator;

import au.com.dius.pact.consumer.MockServer;
import au.com.dius.pact.consumer.dsl.PactDslJsonBody;
import au.com.dius.pact.consumer.dsl.PactDslWithProvider;
import au.com.dius.pact.consumer.junit5.PactConsumerTestExt;
import au.com.dius.pact.consumer.junit5.PactTestFor;
Expand Down Expand Up @@ -67,8 +66,6 @@ RequestResponsePact downloadDocument(PactDslWithProvider builder) throws JSONExc
.headers(AUTHORIZATION_HEADER, someAuthToken)
.path("/cases/documents/" + someDocumentId)
.willRespondWith()
.matchHeader(org.springframework.http.HttpHeaders.CONTENT_TYPE,
"application/vnd.uk.gov.hmcts.dm.document.v1+hal+json;charset=UTF-8")
.status(HttpStatus.SC_OK)
.toPact();
}
Expand Down Expand Up @@ -97,8 +94,6 @@ RequestResponsePact noAuthDownloadDocument(PactDslWithProvider builder) throws J
.headers(SERVICE_AUTHORIZATION_HEADER, invalidServiceAuthToken)
.path("/cases/documents/" + someDocumentId)
.willRespondWith()
.matchHeader(org.springframework.http.HttpHeaders.CONTENT_TYPE,
"application/vnd.uk.gov.hmcts.dm.document.v1+hal+json;charset=UTF-8")
.status(HttpStatus.SC_INTERNAL_SERVER_ERROR)
.toPact();
}
Expand All @@ -119,11 +114,6 @@ public void verifyNoAuthDownloadDocument(MockServer mockServer) throws IOExcepti
RequestResponsePact uploadDocument(PactDslWithProvider builder) throws JSONException, IOException {
// @formatter:off

PactDslJsonBody body = new PactDslJsonBody()
.stringMatcher("caseTypeId", "PRLAPPS")
.stringMatcher("jurisdictionId", "PRIVATELAW")
.asBody();

return builder
.given("A request to upload a document")
.uponReceiving("a request to upload a document with valid authorization")
Expand Down