chore: Make it possible to use Lombok in Kotlin code#2392
chore: Make it possible to use Lombok in Kotlin code#2392sgcr wants to merge 1 commit intoho-dev:masterfrom
Conversation
ab2f206 to
596e58c
Compare
769277d to
d623101
Compare
|
There are 2 not-so-important points that bother me about the Lombok issue:
Regarding the aspect of Java versus Kotlin, I am very interested in how we can find a way to an Android release, as more and more users are asking for such support. At the moment, apart from this idea, there is neither a concrete roadmap nor a driver. As I understand, your proposed changes are especially for kotlin code to make the java lomboks usable. As far as we are using lombok, i will accept their usage. |
As well as polluting git history with a significant number of changes that are only cosmetic in nature. At this point, I feel there is no point in me arguing, so be it. |
9043c10 to
c94991b
Compare
|
I really have to say that I am still not a fan of using Lombok. In my opinion, it doesn't make the code any clearer and currently causes a flood of analyzer warnings in IntelliJ, which makes reviewing quite inconvenient. |
Which analyzer warnings do you mean? From experience, a “flood” of Lombok-related warnings in IntelliJ is often caused by setup or inspection configuration rather than the code itself. If annotation processing (or Lombok support) isn’t enabled in IntelliJ, the IDE may not recognize the generated methods (getters/setters/builders/constructors), which then cascades into lots of false positives (e.g., “cannot resolve method”, “field is never used”, etc.). Please check these two points:
|
5f00fa9 to
051a20f
Compare
051a20f to
d0eab74
Compare
changes proposed in this pull request:
Make it possible to use Lombok in Kotlin code.
src/main/resources/release_notes.md...