#2379 Fix player table selection refresh#2393
Merged
wsbrenk merged 32 commits intoho-dev:masterfrom Jan 27, 2026
Merged
Conversation
sgcr
reviewed
Jan 17, 2026
sgcr
reviewed
Jan 17, 2026
sgcr
reviewed
Jan 17, 2026
sgcr
reviewed
Jan 17, 2026
sgcr
reviewed
Jan 17, 2026
sgcr
reviewed
Jan 17, 2026
sgcr
reviewed
Jan 17, 2026
sgcr
reviewed
Jan 17, 2026
src/main/java/core/gui/comp/renderer/HODefaultTableCellRenderer.java
Outdated
Show resolved
Hide resolved
sgcr
reviewed
Jan 17, 2026
sgcr
reviewed
Jan 17, 2026
sgcr
reviewed
Jan 17, 2026
sgcr
reviewed
Jan 17, 2026
sgcr
reviewed
Jan 17, 2026
sgcr
reviewed
Jan 17, 2026
sgcr
reviewed
Jan 17, 2026
sgcr
reviewed
Jan 17, 2026
sgcr
reviewed
Jan 17, 2026
sgcr
reviewed
Jan 17, 2026
sgcr
reviewed
Jan 17, 2026
sgcr
reviewed
Jan 17, 2026
sgcr
reviewed
Jan 25, 2026
sgcr
reviewed
Jan 25, 2026
sgcr
requested changes
Jan 25, 2026
sgcr
requested changes
Jan 25, 2026
sgcr
requested changes
Jan 25, 2026
sgcr
reviewed
Jan 25, 2026
sgcr
reviewed
Jan 25, 2026
sgcr
reviewed
Jan 25, 2026
sgcr
requested changes
Jan 25, 2026
sgcr
reviewed
Jan 26, 2026
sgcr
reviewed
Jan 26, 2026
sgcr
requested changes
Jan 27, 2026
Collaborator
sgcr
left a comment
There was a problem hiding this comment.
See comment for IllegalArgumentException.
| addTableSelectionListeners(); | ||
| RefreshManager.instance().registerRefreshable(this); | ||
| this.playerOverviewTable.addListSelectionListener(e -> selectPlayer()); | ||
| this.playerOverviewTable.setRowSelectionInterval(0, 0); |
Collaborator
There was a problem hiding this comment.
I got a IllegalArgumentException triggered from here when starting the application:
java.lang.IllegalArgumentException: Row index out of range
at java.desktop/javax.swing.JTable.boundRow(JTable.java:2207)
at java.desktop/javax.swing.JTable.setRowSelectionInterval(JTable.java:2230)
at core.gui.comp.table.FixedColumnsTable.setRowSelectionInterval(FixedColumnsTable.kt:218)
at module.playeroverview.PlayerOverviewPanel.<init>(PlayerOverviewPanel.java:39)
at module.playeroverview.PlayerOverviewModule.createTabPanel(PlayerOverviewModule.java:28)
at core.gui.comp.tabbedPane.HOTabbedPane.showTab(HOTabbedPane.java:38)
at core.gui.HOMainFrame.initComponents(HOMainFrame.java:331)
at core.gui.HOMainFrame.<init>(HOMainFrame.java:110)
at core.gui.HOMainFrame.instance(HOMainFrame.java:169)
at core.HO.lambda$main$1(HO.java:232)
at java.desktop/java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:318)
at java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:771)
at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:722)
at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:716)
at java.base/java.security.AccessController.doPrivileged(AccessController.java:399)
at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:86)
at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:741)
at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:203)
at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:124)
at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:113)
at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:109)
at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:90)
Collaborator
Author
There was a problem hiding this comment.
Thanks - Pushed a fix.
sgcr
approved these changes
Jan 27, 2026
Collaborator
sgcr
left a comment
There was a problem hiding this comment.
Don't forget to squash it all together. :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes proposed in this pull request:
The error was caused by a series of selection listeners that triggered each other. By using the central PlayersTable, selection is now controlled in a single place. This also gives us overarching synchronization of player selection in the Training and Player Overview modules.
src/main/resources/release_notes.md...