Draft
Conversation
Owner
|
I like the JSON, but I wonder about the Rust structs. I'm guessing this stuff will be super niche, so it might be premature to go that far. What about just adding the JSON to start with, and then we can see what use cases develop? That would also postpone the need to hammer out the nuances you've mentioned for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like to include the common fighter attribute values in this repository. Many of these values are useful to have an exact reference. For example weight, friction, jumpsquat_frames, aerial landing lags, turn_duration, etc. However, many are also not useful. There are also some attributes whose purpose is unknown.
These values were generated directly from game files using this fork https://github.com/NickCondron/meleeDat2Json/tree/update-attributes based on various sources for known attributes and their types.
This PR is a WIP because I'd like your feedback on how best to organize the data for inclusion in this repo. I have 32 json files just like the mario.json file in the PR, and I created an example of the corresponding rust module could be organized.