fix enum key encoding for strings: true enums#85
Open
CameronTofer wants to merge 1 commit intoholepunchto:mainfrom
Open
fix enum key encoding for strings: true enums#85CameronTofer wants to merge 1 commit intoholepunchto:mainfrom
CameronTofer wants to merge 1 commit intoholepunchto:mainfrom
Conversation
When an enum with `strings: true` was used as part of a collection key, inserting a record would crash with "Invalid number <value>" because the codegen always generated IndexEncoder.UINT for enum key components, regardless of the strings flag. This meant string values like "pending" were passed to UINT.encode() which expects integers. Now checks keyType.strings and uses IndexEncoder.STRING when true. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
strings: trueas part of a collection keyIndexEncoder.UINTfor enum key components, causing "Invalid number" errors when string values were passedkeyType.stringsand usesIndexEncoder.STRINGwhen trueTest plan
strings: trueenum in collection keyenum with strings: true as key type🤖 Generated with Claude Code