Fix float16 being a floating type.#1290
Merged
ianthomas23 merged 1 commit intoholoviz:mainfrom Oct 16, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1290 +/- ##
=======================================
Coverage 85.73% 85.73%
=======================================
Files 52 52
Lines 10870 10870
=======================================
Hits 9319 9319
Misses 1551 1551
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This basically applies the following: blaze/datashape#241 to the vendored datashape.
Fixes an issue where float16 is not recognized as a floating type (and as a result as a real type, which makes it not work in plots).