-
-
Notifications
You must be signed in to change notification settings - Fork 956
Allow settings auto favorite from automotive #6718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
2657805
65f3651
b9f75c1
ceebc75
03b9cc0
1e42075
251f8a2
74cc6f1
e2cd297
82f2143
ce72bb6
2bb7210
f39eaf4
df516d2
d43b4aa
a473bc0
13129c8
b65ce01
ee5a158
622c276
6da3ba5
62465f1
4af0bf0
2df7f86
51bd2d3
b413653
0ed7c46
3b44395
0a74259
2782057
9c2ca73
d9e331b
80bcfc0
10f6bf9
b622996
e91c50c
1fed001
dea98ca
02dffc4
17cf7ad
9bab495
e395938
00c7879
86b234e
d58dba4
216a401
e65e004
f7ed752
f438fee
cb34a67
edb2625
9358e49
db57201
549a9ee
bcabf58
a038ae6
1917abf
a4007d5
95e5972
54be43f
b8729b2
110f7fa
fea1237
d856a5c
e75da42
13782f1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,6 +16,7 @@ import io.homeassistant.companion.android.common.util.isAutomotive | |
| import io.homeassistant.companion.android.util.vehicle.SUPPORTED_DOMAINS | ||
| import io.homeassistant.companion.android.util.vehicle.getDomainList | ||
| import io.homeassistant.companion.android.util.vehicle.getHeaderBuilder | ||
| import io.homeassistant.companion.android.util.vehicle.getManageFavoritesAction | ||
| import io.homeassistant.companion.android.util.vehicle.nativeModeAction | ||
| import kotlinx.coroutines.flow.Flow | ||
| import kotlinx.coroutines.flow.StateFlow | ||
|
|
@@ -71,8 +72,20 @@ class DomainListScreen( | |
|
|
||
| return GridTemplate.Builder().apply { | ||
| val headerBuilder = carContext.getHeaderBuilder(R.string.all_entities) | ||
| if (isAutomotive && !isDrivingOptimized && BuildConfig.FLAVOR != "full") { | ||
| headerBuilder.addEndHeaderAction(nativeModeAction(carContext)) | ||
| if (isAutomotive && !isDrivingOptimized) { | ||
| if (BuildConfig.FLAVOR != "full") { | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it's a shame that we can't use your screen also in minimal flavor. You should consider a UI that would allow both the native button and add favorite to be displayed.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could you add a screenshot showing both? |
||
| headerBuilder.addEndHeaderAction(nativeModeAction(carContext)) | ||
| } | ||
|
|
||
| headerBuilder.addEndHeaderAction( | ||
| getManageFavoritesAction( | ||
| carContext, | ||
| screenManager, | ||
| serverId, | ||
| allEntities, | ||
| prefsRepository, | ||
| ), | ||
| ) | ||
| } | ||
| setHeader(headerBuilder.build()) | ||
| val domainBuild = domainList.build() | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.