Move the debug flag for WebView into the Application and Settings#6813
Open
Move the debug flag for WebView into the Application and Settings#6813
Conversation
TimoPtr
added
the
WebViewActivity replacement
48 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR centralizes WebView remote debugging enablement by moving the WebView.setWebContentsDebuggingEnabled(...) call out of WebViewActivity and into app-level startup plus the Developer Settings toggle, aiming to apply the setting globally and immediately when changed.
Changes:
- Remove WebView debugging preference plumbing from
WebViewPresenter/WebViewPresenterImpland stop setting it fromWebViewActivity - Apply the saved WebView remote debugging setting during
HomeAssistantApplicationstartup - Apply WebView remote debugging immediately when toggled in Developer Settings
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| app/src/main/kotlin/io/homeassistant/companion/android/webview/WebViewPresenterImpl.kt | Removes the presenter method that exposed the WebView debug preference |
| app/src/main/kotlin/io/homeassistant/companion/android/webview/WebViewPresenter.kt | Removes isWebViewDebugEnabled() from the presenter interface |
| app/src/main/kotlin/io/homeassistant/companion/android/webview/WebViewActivity.kt | Stops enabling WebView debugging from the activity lifecycle |
| app/src/main/kotlin/io/homeassistant/companion/android/settings/developer/DeveloperSettingsPresenterImpl.kt | Enables/disables WebView debugging immediately when the developer preference is toggled |
| app/src/main/kotlin/io/homeassistant/companion/android/HomeAssistantApplication.kt | Attempts to apply the saved WebView debugging setting on app startup |
| @@ -99,6 +100,7 @@ open class HomeAssistantApplication : | |||
| registerActivityLifecycleCallbacks(LifecycleHandler) | |||
|
|
|||
jpelgrom
approved these changes
May 7, 2026
Member
jpelgrom
left a comment
jpelgrom
left a comment
There was a problem hiding this comment.
Verified. I don't see a new race happening here as this should result in it being set earlier in the lifecycle, but good to stay alert to reports of it not working.
| registerActivityLifecycleCallbacks(LifecycleHandler) | ||
|
|
||
| ioScope.launch { | ||
| WebView.setWebContentsDebuggingEnabled(BuildConfig.DEBUG || prefsRepository.isWebViewDebugEnabled()) |
Member
There was a problem hiding this comment.
You may want to consider moving this down in this block so if it crashes we actually have crash reporting enabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move the set of the debug capability of the WebView at the Application level and also in the settings level. The idea is to enable/disable it globally so that it apply right away when changing and also when the app starts.
There is a risk where maybe the debug flag is set after the webview load since it uses the ioScope in the Application but I'm not sure.