Bump python-roborock to 3.3.3#155170
Conversation
This is a breaking change that required these changes: - Importing containers and data - Changes to some dataclass computed values This is also required for home-assistant#154837 which will switch to another API within the same library.
home-assistant
Bot
added
cla-signed
dependency
|
Hey there @Lash-L, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the python-roborock library from version 2.50.2 to 3.3.3, which includes breaking API changes in the library structure. The upgrade involves updating import paths from roborock.containers and roborock.code_mappings to the consolidated roborock.data module, and adapting to changes in dataclass computed properties.
Key changes:
- Import path updates across all roborock integration files to use
roborock.datainstead of the deprecated modules - Updated test code to use enum values instead of string properties for state representation
- Removed computed/derived fields from diagnostic snapshots that are no longer provided by the library
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| homeassistant/components/roborock/*.py (8 files) | Updated imports from roborock.containers and roborock.code_mappings to roborock.data |
| homeassistant/components/roborock/manifest.json | Bumped python-roborock requirement from 2.50.2 to 3.3.3 |
| requirements_all.txt | Updated python-roborock version to 3.3.3 |
| requirements_test_all.txt | Updated python-roborock version to 3.3.3 |
| tests/components/roborock/test_image.py | Changed test to use RoborockStateCode.docking enum instead of string property state_name |
| tests/components/roborock/mock_data.py | Updated import from roborock.containers to roborock.data |
| tests/components/roborock/conftest.py | Updated import from roborock.code_mappings to roborock.data |
| tests/components/roborock/snapshots/test_diagnostics.ambr | Removed computed/derived fields that are no longer present in the library's dataclasses |
thecode
left a comment
thecode
left a comment
There was a problem hiding this comment.
Changes looks OK, but there is no changelog/diff for the updated dependency
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
can you mark as fixing #154571? |
Fixed, now marking ready for review. |
Proposed change
This library has breaking API changes, though not user facing breakages, that required these changes:
This is also required for #154837 which will switch to another API within the same library.
Changes: Python-roborock/python-roborock@v2.50.2...v3.3.3
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: