Skip to content

Update roborock test typing#157370

Merged
balloob merged 4 commits intohome-assistant:devfrom
allenporter:roborock-test-typing
Nov 27, 2025
Merged

Update roborock test typing#157370
balloob merged 4 commits intohome-assistant:devfrom
allenporter:roborock-test-typing

Conversation

@allenporter
Copy link
Copy Markdown
Contributor

Proposed change

Address PR feedback from #154837 on cleaning up test typing to be more explicit.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown

Hey there @Lash-L, mind taking a look at this pull request as it has been labeled with an integration (roborock) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of roborock can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign roborock Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves test typing in the Roborock integration by making mock object types more explicit. The changes address feedback from PR #154837 to enhance type safety and clarity in test code.

Key changes:

  • Refactored mock creation into reusable make_mock_trait and make_mock_switch helper functions
  • Added explicit type annotations with trait specs (e.g., StatusTrait, DoNotDisturbTrait, CommandTrait)
  • Renamed send_message_side_effect to send_message_exception for better semantic clarity
  • Imported specific trait types to enable proper mock specifications

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
tests/components/roborock/conftest.py Added trait-specific imports, refactored mock creation into typed helper functions (make_mock_trait, make_mock_switch), updated fixture typing from send_message_side_effect to send_message_exception
tests/components/roborock/test_switch.py Updated test parameter name from send_message_side_effect to send_message_exception to match fixture renaming

Comment thread tests/components/roborock/conftest.py Outdated
Comment thread tests/components/roborock/conftest.py Outdated
Comment thread tests/components/roborock/conftest.py Outdated
Comment thread tests/components/roborock/conftest.py Outdated
Comment thread tests/components/roborock/conftest.py Outdated
@allenporter allenporter marked this pull request as draft November 26, 2025 20:45
@allenporter allenporter marked this pull request as ready for review November 26, 2025 20:59
@balloob balloob merged commit bd84dac into home-assistant:dev Nov 27, 2025
36 checks passed
@frenck frenck added this to the 2025.12.0 milestone Nov 27, 2025
frenck pushed a commit that referenced this pull request Nov 27, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants