Update roborock test typing#157370
Merged
balloob merged 4 commits intohome-assistant:devfrom Nov 27, 2025
Merged
Conversation
|
Hey there @Lash-L, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves test typing in the Roborock integration by making mock object types more explicit. The changes address feedback from PR #154837 to enhance type safety and clarity in test code.
Key changes:
- Refactored mock creation into reusable
make_mock_traitandmake_mock_switchhelper functions - Added explicit type annotations with trait specs (e.g.,
StatusTrait,DoNotDisturbTrait,CommandTrait) - Renamed
send_message_side_effecttosend_message_exceptionfor better semantic clarity - Imported specific trait types to enable proper mock specifications
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| tests/components/roborock/conftest.py | Added trait-specific imports, refactored mock creation into typed helper functions (make_mock_trait, make_mock_switch), updated fixture typing from send_message_side_effect to send_message_exception |
| tests/components/roborock/test_switch.py | Updated test parameter name from send_message_side_effect to send_message_exception to match fixture renaming |
balloob
approved these changes
Nov 27, 2025
frenck
pushed a commit
that referenced
this pull request
Nov 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Address PR feedback from #154837 on cleaning up test typing to be more explicit.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: